This repository was archived by the owner on Aug 17, 2024. It is now read-only.
express-workshop-all steps#5
Open
Behnazz wants to merge 1 commit intoCodeYourFuture:masterfrom
Behnazz:master
Open
express-workshop-all steps#5Behnazz wants to merge 1 commit intoCodeYourFuture:masterfrom Behnazz:master
Behnazz wants to merge 1 commit intoCodeYourFuture:masterfrom
Behnazz:master
Conversation
nennes
reviewed
Jul 21, 2018
| { | ||
| "1467390356291": "This is my very first blog post!" | ||
| } | ||
| ["[\"[\\\"[\\\\\\\"[\\\\\\\\\\\\\\\"[\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"{\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\n \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"1467390356291\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\": \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"This is my very first blog post!\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\n}\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\n\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\",{\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"1531861103496\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\":\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"Hi\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"}]\\\\\\\\\\\\\\\",{\\\\\\\\\\\\\\\"1531861155200\\\\\\\\\\\\\\\":\\\\\\\\\\\\\\\"Hello\\\\\\\\\\\\\\\"}]\\\\\\\",{\\\\\\\"1531861738283\\\\\\\":\\\\\\\"check\\\\\\\"}]\\\",{\\\"1531861917411\\\":\\\"First\\\"}]\",{\"1531861944247\":\"second\"}]",{"1531861944627":"second"}] No newline at end of file |
There was a problem hiding this comment.
why are there all these backslashes in the JSON?
There was a problem hiding this comment.
this should just be an array of objects
nennes
reviewed
Jul 21, 2018
|
|
||
| app.post("/create-post", function (req, res) { | ||
| fs.readFile(__dirname + "/data/posts.json", function (error, file) { | ||
| const parsedFile = JSON.parse(file); |
There was a problem hiding this comment.
you are turning the file contents into an object, why are you not adding the data to this object?
nennes
reviewed
Jul 21, 2018
| fs.readFile(__dirname + "/data/posts.json", function (error, file) { | ||
| const parsedFile = JSON.parse(file); | ||
| var storage = []; | ||
| storage.push(file.toString()); |
There was a problem hiding this comment.
why push the entire file as a string into the array?
nennes
reviewed
Jul 21, 2018
| const parsedFile = JSON.parse(file); | ||
| var storage = []; | ||
| storage.push(file.toString()); | ||
| storage.push({ [Date.now()]: req.fields["blogpost"] }) |
There was a problem hiding this comment.
not you have a array that contains a string representation of an array and another object. Not what you'd want.
nennes
reviewed
Jul 21, 2018
| var storage = []; | ||
| storage.push(file.toString()); | ||
| storage.push({ [Date.now()]: req.fields["blogpost"] }) | ||
| fs.writeFile("./data/posts.json", JSON.stringify(storage), function (error) { |
There was a problem hiding this comment.
When you stringify this, you end up with the crazy contents in your file.
Make sure you have the correct object structure before writing it back into the file.
nennes
suggested changes
Jul 21, 2018
nennes
left a comment
nennes
left a comment
There was a problem hiding this comment.
Please fix the JSON parsing and also complete the Handlebars part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.