Skip to content

London|ITP-Jan-2026|Ping Wang|Sprint 3|2-practice-tdd#1120

Open
pathywang wants to merge 5 commits intoCodeYourFuture:mainfrom
pathywang:Sprint-3/-2
Open

London|ITP-Jan-2026|Ping Wang|Sprint 3|2-practice-tdd#1120
pathywang wants to merge 5 commits intoCodeYourFuture:mainfrom
pathywang:Sprint-3/-2

Conversation

@pathywang
Copy link

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

After i did prop, i did couusework and checked with node and npx jest to make sure the code is working ok

@pathywang pathywang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 1, 2026
@hkavalikas hkavalikas self-requested a review March 2, 2026 07:50
@hkavalikas hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 2, 2026
count++
}
}
return count}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the closed bracket to a new line for readability, but it looks great otherwise!

@hkavalikas hkavalikas added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 2, 2026
@hkavalikas
Copy link

Awesome work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants