Skip to content

London | JAN-ITP-26 | Kayanat Suleman | Sprint 3 | Alarm Clock App#969

Open
KayanatSuleman wants to merge 5 commits intoCodeYourFuture:mainfrom
KayanatSuleman:feature/alarm-clock
Open

London | JAN-ITP-26 | Kayanat Suleman | Sprint 3 | Alarm Clock App#969
KayanatSuleman wants to merge 5 commits intoCodeYourFuture:mainfrom
KayanatSuleman:feature/alarm-clock

Conversation

@KayanatSuleman
Copy link

@KayanatSuleman KayanatSuleman commented Feb 27, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Updated index.html title to “Alarm clock app”
  • Implemented setAlarm() logic in alarmclock.js
  • Added time formatting to display input in mm:ss
  • Implemented countdown functionality using setInterval
  • Updated heading every 1000ms while counting down
  • Triggered playAlarm() when timer reaches 00:00
  • Cleared interval when countdown completes to prevent negative values
  • Ensured all provided Jest tests pass

@KayanatSuleman KayanatSuleman added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Feb 27, 2026
Copy link

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues with your alarm clock app:

  • When I click on the set alarm button, the timer starts counting backwards.
  • When I click on the set alarm button, without entrying any number in the input box, I don't get any alert message, instead the timer just starts counting backwards. I should not be able to set an alarm on an empty input box.
  • Your input box accepts negative numbers, it should not.

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Groups The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants