Fix Language Servers settings page UI and search#2171
Fix Language Servers settings page UI and search#2171ayush-that wants to merge 1 commit intoCodeEditApp:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes several UI/UX issues on the Language Servers settings page (issue #2157 - missing search functionality). It replaces the broken ZStack-based "Show More" overlay in each row with a clean single-line description, adds a proper SearchField with word-prefix matching (replacing the toolbar-based .searchable() + fuzzy search), switches from List to LazyVStack for better scroll performance, and improves the experimental warning banner styling. Unused code (getInfoString(), showingInfoPanel) is also removed.
Changes:
- Replaces toolbar-based fuzzy search with a dedicated
SearchFieldsection and word-prefix filtering inLanguageServersView - Replaces
ListwithLazyVStack+ForEach, restyling the warning banner and layout to match theThemeSettingsViewpattern - Removes the
ZStack-based "Show More/Less" expandable description inLanguageServerRowView, replacing it with a single truncated description line
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
LanguageServersView.swift |
Adds SearchField, word-prefix filtering, LazyVStack layout, improved warning banner, and removes the FuzzySearchUIModel dependency |
LanguageServerRowView.swift |
Removes the broken showMore/ZStack overlay; shows a single truncated description line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
- Replace broken ZStack overlay in LanguageServerRowView with clean VStack layout and single-line description - Replace .searchable() toolbar search with SearchField in a Section to match other settings pages - Replace List with LazyVStack for scroll performance - Replace fuzzy search with word-prefix matching for more intuitive filtering results - Style warning banner inline with small yellow icon matching Apple System Settings pattern - Remove unused getInfoString()
ayush-that
force-pushed
the
fix/language-servers-settings-ui
branch
from
0fbcfa6 to
9780995
Compare
Description
fixes several ui/ux issues on the language servers settings page:
ZStackoverlay ("Show More" button with background rectangle hack that caused text collision) with a cleanVStacklayout showing a single-line description.searchable()toolbar search withSearchFieldin its ownSection, matching the pattern used by other settings pages (e.g. themes). replacedListwithLazyVStackfor scroll performance with hundreds of registry itemsgetInfoString()andshowingInfoPanelRelated Issues
Checklist
Screenshots
Before
After
CodeEdit.mp4