Skip to content

Error msg for passenger fit rating#76

Merged
promatty merged 1 commit intomainfrom
SANC-107-descriptive-error-for-passenger-fitness
Apr 10, 2026
Merged

Error msg for passenger fit rating#76
promatty merged 1 commit intomainfrom
SANC-107-descriptive-error-for-passenger-fitness

Conversation

@JustinTan-1
Copy link
Copy Markdown
Contributor

@JustinTan-1 JustinTan-1 commented Apr 8, 2026

image

Summary by CodeRabbit

  • Bug Fixes
    • Improved validation error display for the passenger fitness rating. When validation errors occur, the rating field now displays a red border with adjusted styling, and error messages appear below the rating labels for clearer user feedback.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
salvationarmy Ready Ready Preview, Comment Apr 8, 2026 5:50pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 87069185-817b-4f47-b05f-2a80cad65e82

📥 Commits

Reviewing files that changed from the base of the PR and between edfd191 and e721452.

📒 Files selected for processing (1)
  • src/app/_components/drivercomponents/TripSurveyModal.tsx

📝 Walkthrough

Walkthrough

Updated the passenger fitness rating UI component to display validation error states with conditional red border styling and error message rendering when the form field has validation errors.

Changes

Cohort / File(s) Summary
Passenger Fitness Rating Validation
src/app/_components/drivercomponents/TripSurveyModal.tsx
Added conditional error styling to rating container (red border, adjusted borderRadius/padding) and error message display when passengerFitRating validation errors are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • themaxboucher
  • promatty
  • tanvimahal
  • Yemyam

Poem

🐰 A hop and a skip through the validation dance,
Red borders now glow when errors enhance,
The rating field speaks with messages so clear,
Survey feedback flows without any fear! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding error messaging for the passenger fitness rating field validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch SANC-107-descriptive-error-for-passenger-fitness

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@promatty promatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@promatty promatty merged commit d64d0bc into main Apr 10, 2026
4 checks passed
@promatty promatty deleted the SANC-107-descriptive-error-for-passenger-fitness branch April 10, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants