Skip to content

fix: reenable walltime instrument hooks #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
art049 merged 1 commit into from
Jun 10, 2025
Merged

fix: reenable walltime instrument hooks #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/pytest_codspeed/instruments/walltime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ def __codspeed_root_frame__() -> T:
# Benchmark
iter_range = range(iter_per_round)
run_start = perf_counter_ns()
if self.instrument_hooks:
self.instrument_hooks.start_benchmark()
for _ in range(rounds):
start = perf_counter_ns()
for _ in iter_range:
Expand All @@ -234,6 +236,9 @@ def __codspeed_root_frame__() -> T:
if end - run_start > benchmark_config.max_time_ns:
# TODO: log something
break
if self.instrument_hooks:
self.instrument_hooks.stop_benchmark()
self.instrument_hooks.set_executed_benchmark(uri)
benchmark_end = perf_counter_ns()
total_time = (benchmark_end - run_start) / 1e9

Expand All @@ -250,7 +255,7 @@ def __codspeed_root_frame__() -> T:
)
return out

def measure_pedantic(
def measure_pedantic( # noqa: C901
self,
marker_options: BenchmarkMarkerOptions,
pedantic_options: PedanticOptions[T],
Expand All @@ -277,6 +282,8 @@ def __codspeed_root_frame__(*args, **kwargs) -> T:
# Benchmark
times_per_round_ns: list[float] = []
benchmark_start = perf_counter_ns()
if self.instrument_hooks:
self.instrument_hooks.start_benchmark()
for _ in range(pedantic_options.rounds):
start = perf_counter_ns()
args, kwargs = pedantic_options.setup_and_get_args_kwargs()
Expand All @@ -286,7 +293,9 @@ def __codspeed_root_frame__(*args, **kwargs) -> T:
times_per_round_ns.append(end - start)
if pedantic_options.teardown is not None:
pedantic_options.teardown(*args, **kwargs)

if self.instrument_hooks:
self.instrument_hooks.stop_benchmark()
self.instrument_hooks.set_executed_benchmark(uri)
benchmark_end = perf_counter_ns()
total_time = (benchmark_end - benchmark_start) / 1e9
stats = BenchmarkStats.from_list(
Expand Down