Handle non-numeric order in _ct_after_save#486
Merged
seuros merged 1 commit intoClosureTree:masterfrom Mar 7, 2026
Merged
Conversation
Only run reorder/scope-change logic when the order column is numeric. The _ct_after_save flow was restructured to guard calls to _ct.scope_changed? and sibling reordering with _ct.order_is_numeric?, preventing errors when models use a non-numeric order column.
Contributor
Author
|
@seuros This PR is ready for review. Please take a look when you get a chance. Thank you. |
Member
|
thanks for the fix and the regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle non-numeric order in
_ct_after_saveOnly run reorder/scope-change logic when the order column is numeric. The
_ct_after_saveflow was restructured to guard calls to_ct.scope_changed?and sibling reordering with_ct.order_is_numeric?, preventing errors when models use a non-numeric order column.Fixes undefined method `_ct_reorder_siblings' for an instance of Tag