Add Support for CH579M#437
Merged
fpoussin merged 3 commits intoChibiOS:chibios-21.11.xfrom Apr 8, 2026
Merged
Conversation
This was referenced Mar 15, 2026
…ght be later in qmk firmware
This was referenced Mar 20, 2026
Member
|
Thank you! |
zvecr
reviewed
Apr 9, 2026
Comment on lines
+20
to
+25
| $(KEYBOARD_PATH_1)/ld | ||
|
|
||
| STARTUPLD = $(CHIBIOS)/os/common/startup/ARMCMx/compilers/GCC/ld | ||
| STARTUPLD_CONTRIB = $(KEYBOARD_PATH_1)/ld | ||
|
|
||
| LDFLAGS += -L$(KEYBOARD_PATH_1)/ld |
There was a problem hiding this comment.
KEYBOARD_PATH_1 is a QMK specific variable, and should not have been included in this lower layer dependency.
Contributor
Author
|
Should I just submit a patch or would you prefer revert and resubmit?
…On Thu, 9 Apr 2026, 07:51 Joel Challis, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In os/common/startup/ARMCMx/compilers/GCC/mk/startup_ch579m.mk
<#437 (comment)>
:
> + $(KEYBOARD_PATH_1)/ld
+
+STARTUPLD = $(CHIBIOS)/os/common/startup/ARMCMx/compilers/GCC/ld
+STARTUPLD_CONTRIB = $(KEYBOARD_PATH_1)/ld
+
+LDFLAGS += -L$(KEYBOARD_PATH_1)/ld
KEYBOARD_PATH_1 is a QMK specific variable, and should not have been
included in this lower layer dependency.
—
Reply to this email directly, view it on GitHub
<#437 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHR6OMP4NJBRDIXVKU6IIL4U5B57AVCNFSM6AAAAACWSMDRK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DAOBQGIZDAMRTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of the CH579M chip as i have a cheap macropad with that chip that does not support qmk.
This port is a pre-req QMK.
Notes:
This is heavily AI (Claude) assisted as this is not an area i am familiar with. I've marked WIP as I'm still working on the QMK part and there may be further tweaks needed at time of PR QMK Compiles, and is recognised by the host system, and qmk console can connect to keyboard.
This has enough now that QMK can build and work. There might be other features people want e.g. BLE etc but i dont have a board with that so cant test and i have scrubbed this boards Analog keys so i am now limited in what i can do without bodge wires.