Merged
Conversation
Owner
|
Thanks for the PR! |
Contributor
Author
|
Nothing's changed really so things should just work. The changes are actually unrelated, likely because of updates in rustc. Can change it to Full disclosure: I'm on Windows so I'm just relying on CI to to catch issues. |
Owner
|
Yes, I would prefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upcoming version 0.18 of cpal conflicts with lower alsa-sys versions.
I didn't really do anything except bump the version, but the previous code specifically had alsa = ">=0.9.0, <0.11", so maybe I'm missing something?
(Also some minor fixes in unrelated code to make CI pass.)