Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/sdk-coin-polyx/src/lib/transactionBuilderFactory.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BaseTransactionBuilderFactory, NotImplementedError } from '@bitgo/sdk-core';
import { BaseTransactionBuilderFactory } from '@bitgo/sdk-core';
import { BaseCoin as CoinConfig } from '@bitgo/statics';
import { decode } from '@substrate/txwrapper-polkadot';
import { TransferBuilder } from './transferBuilder';
Expand Down Expand Up @@ -67,8 +67,8 @@ export class TransactionBuilderFactory extends BaseTransactionBuilderFactory {
return new WithdrawUnbondedBuilder(this._coinConfig).material(this._material);
}

getWalletInitializationBuilder(): void {
throw new NotImplementedError(`walletInitialization for ${this._coinConfig.name} not implemented`);
getWalletInitializationBuilder(): RegisterDidWithCDDBuilder {
return this.getRegisterDidWithCDDBuilder();
}

from(rawTxn: string): TransactionBuilder<TxMethod, SupportedTransaction> {
Expand Down
8 changes: 8 additions & 0 deletions modules/sdk-coin-polyx/src/polyx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,14 @@ export class Polyx extends SubstrateCoin {
return { transactions: broadcastableTransactions, lastScanIndex };
}

/**
* Polyx requires a wallet initialization transaction (RegisterDidWithCDD)
* to create an on-chain identity before the address can receive funds.
*/
requiresWalletInitializationTransaction(): boolean {
return true;
}

/**
* Gets config for how token enablements work for this coin
* @returns
Expand Down
14 changes: 14 additions & 0 deletions modules/sdk-coin-polyx/test/unit/polyx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,20 @@ describe('Polyx:', function () {
});
});

describe('Address Creation Flow:', function () {
it('should require wallet initialization transaction', function () {
const mainCoin = bitgo.coin('polyx') as Polyx;
mainCoin.requiresWalletInitializationTransaction().should.equal(true);
baseCoin.requiresWalletInitializationTransaction().should.equal(true);
});

it('should return a RegisterDidWithCDDBuilder from getWalletInitializationBuilder', function () {
const { RegisterDidWithCDDBuilder } = require('../../src/lib');
const builder = baseCoin.getBuilder().getWalletInitializationBuilder();
builder.should.be.instanceOf(RegisterDidWithCDDBuilder);
});
});

describe('Token Enablement:', function () {
it('should have correct token enablement config', function () {
const config = baseCoin.getTokenEnablementConfig();
Expand Down
Loading