fix(express): prevent double-stringify of string payloads in handleV2 OFCSignPayload#8406
Open
CapnMigraine wants to merge 1 commit intomasterfrom
Open
fix(express): prevent double-stringify of string payloads in handleV2 OFCSignPayload#8406CapnMigraine wants to merge 1 commit intomasterfrom
CapnMigraine wants to merge 1 commit intomasterfrom
Conversation
…OFCSignPayload The handler unconditionally called JSON.stringify(payload), which double-stringifies when the io-ts Json codec resolves the input as a string (the common case for tx/build responses). This caused tx/send to reject with 400 invalid signature. Apply the same typeof guard already used in the ext-signing-mode handler. TICKET: CAAS-1186
kaustubhbitgo
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handler unconditionally called JSON.stringify(payload), which double-stringifies when the io-ts Json codec resolves the input as a string (the common case for tx/build responses). This caused tx/send to reject with 400 invalid signature.
Apply the same typeof guard already used in the ext-signing-mode handler.
TICKET: CAAS-1186