Skip to content

Add incident report: cache eviction closes in-use httpx clients#22309

Open
ryan-crabbe wants to merge 1 commit intomainfrom
litellm_blog_httpx_cache_incident_report
Open

Add incident report: cache eviction closes in-use httpx clients#22309
ryan-crabbe wants to merge 1 commit intomainfrom
litellm_blog_httpx_cache_incident_report

Conversation

@ryan-crabbe
Copy link
Collaborator

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem
  • I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

CI (LiteLLM team)

CI status guideline:

  • 50-55 passing tests: main is stable with minor issues.
  • 45-49 passing tests: acceptable but needs attention
  • <= 40 passing tests: unstable; be careful with your merges and assess the risk.
  • Branch creation CI run
    Link:

  • CI run for the last commit
    Link:

  • Merge / cherry-pick CI run
    Links:

Type

📖 Documentation

Changes

Incident report for cache eviction closing in-use httpx clients

@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
litellm Ready Ready Preview, Comment Feb 27, 2026 9:04pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR adds a comprehensive incident report documenting a cache eviction bug that closed in-use httpx clients. The report clearly explains the problem (httpx clients being closed prematurely during cache eviction), the root cause (PR #21717's _remove_key override didn't distinguish between Redis and httpx clients), and the resolution (PR #22247 removed the override). The documentation is well-structured with proper sections, code examples, and references to related PRs.

Confidence Score: 5/5

  • This documentation-only PR is completely safe to merge with zero risk
  • This is a documentation-only change that adds a well-written incident report. No code is modified, no functionality is changed, and the documentation quality is high with clear explanations and proper references
  • No files require special attention

Important Files Changed

Filename Overview
docs/my-website/blog/httpx_cache_eviction_incident/index.md Well-structured incident report documenting cache eviction bug, root cause, and resolution with proper references and technical details

Last reviewed commit: 7ca339a

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant