Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryBumps uvloop from 0.21.0 to 0.22.1 across all dependency files (
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| pyproject.toml | Bumps uvloop version constraint from ^0.21.0 to ^0.22.1. Straightforward dependency version bump. |
| requirements.txt | Pins uvloop to 0.22.1 (from 0.21.0), consistent with pyproject.toml change. |
| .circleci/requirements.txt | Pins uvloop to 0.22.1 for CI, with minor trailing whitespace cleanup. Also adds a trailing newline. |
| .circleci/config.yml | Updates uvloop pip install to 0.22.1, with minor trailing whitespace cleanup in an unrelated section. |
| poetry.lock | Auto-regenerated lock file reflecting uvloop 0.22.1 with updated hashes for all platform wheels. Also picks up a minor litellm-proxy-extras bump (0.4.48 → 0.4.49). |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[pyproject.toml] -->|"uvloop ^0.22.1"| B[poetry.lock]
B -->|"resolves to 0.22.1"| C[poetry install]
D[requirements.txt] -->|"uvloop==0.22.1"| E[Docker Build]
F[.circleci/requirements.txt] -->|"uvloop==0.22.1"| G[CI Tests]
H[.circleci/config.yml] -->|"pip install uvloop==0.22.1"| I[CI Job: test_custom_llm_router]
C --> J[uvicorn --loop uvloop]
E --> J
G --> J
I --> J
J --> K[LiteLLM Proxy Server]
Last reviewed commit: 14696d5
|
|
||
| uvicorn = {version = ">=0.32.1,<1.0.0", optional = true} | ||
| uvloop = {version = "^0.21.0", optional = true, markers="sys_platform != 'win32'"} | ||
| uvloop = {version = "^0.22.1", optional = true, markers="sys_platform != 'win32'"} |
There was a problem hiding this comment.
Version not updated in other files
The uvloop version was bumped in pyproject.toml but several other files still pin 0.21.0:
requirements.txt:21—uvloop==0.21.0.circleci/requirements.txt:15—uvloop==0.21.0.circleci/config.yml:2202—pip install "uvloop==0.21.0"
Additionally, poetry.lock still resolves to uvloop 0.21.0 and was not regenerated as part of this PR. Running poetry lock (or poetry update uvloop) is needed so that poetry install actually pulls in the new version.
Without updating these files, the Docker image (which uses requirements.txt) and CI (which uses .circleci/requirements.txt and config.yml) will continue installing 0.21.0, meaning the fix from #20933 won't actually be deployed.
03da4d1 to
14696d5
Compare
|
Addressed the feedback, please take another look. |
Relevant issues
Fixes #20933
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
I have Added testing in the(not applicable)tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsMy PR passes all unit tests on
make test-unit4 existing errors
My PR's scope is as isolated as possible, it only solves 1 specific problem
I have requested a Greptile review by commenting
@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewCI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Type
🐛 Bug Fix
Changes
Bump uvloop from 0.21.0 to 0.22.1