Skip to content

Add tests for subclassing Point or OrientedPoint instead of Object#405

Merged
dfremont merged 2 commits intoBerkeleyLearnVerify:mainfrom
lola831:test-subclass-point
Mar 31, 2026
Merged

Add tests for subclassing Point or OrientedPoint instead of Object#405
dfremont merged 2 commits intoBerkeleyLearnVerify:mainfrom
lola831:test-subclass-point

Conversation

@lola831
Copy link
Copy Markdown
Collaborator

@lola831 lola831 commented Oct 23, 2025

Description

Adds two tests that assert TypeError when ego is a subclass of Point or OrientedPoint (must subclass Object).

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@lola831 lola831 requested a review from dfremont October 23, 2025 16:16
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (40d8d1d) to head (c3ecf5f).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   89.85%   89.67%   -0.18%     
==========================================
  Files          54       48       -6     
  Lines       13549    13194     -355     
==========================================
- Hits        12174    11832     -342     
+ Misses       1375     1362      -13     

see 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two trivial formatting suggestions.

Co-authored-by: Daniel Fremont <dfremont@ucsc.edu>
Copy link
Copy Markdown
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot I could just apply the suggestions myself, so I did that. Thanks Lola!

@dfremont dfremont merged commit 29f8bd1 into BerkeleyLearnVerify:main Mar 31, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants