fixed OSError message and added file path validation#301
Open
yugui923 wants to merge 1 commit intoBelval:masterfrom
Open
fixed OSError message and added file path validation#301yugui923 wants to merge 1 commit intoBelval:masterfrom
yugui923 wants to merge 1 commit intoBelval:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Belval - thanks for writing and maintaining the pdf2image package!
I created this pull request to correct a miscategorized error message and implement more robust validation logic for inputs. Specifically:
I've added a very simple fix to this error message and added validation logic in this PR
Error message for invlid path after fix:
Error message for invlid path prior to fix: