Graduation management first page by Meatchema · Pull Request #1679 · BCStudentSoftwareDevTeam/celts

Meatchema · 2026-02-19T14:21:38Z

Issue Description

-Miss identified issue (solved) : The problem is that when the graduation check is clicked it says that the status has been confirmed and it works to create the graduated individual. But, if you uncheck their graduation status, they are no longer searchable under the ‘Senior' Status.
-Re-Identification of issue (solved): The actual problem is that from page two and onward if I click graduated for the user, the user will not disappear as they are supposed too. Only page one works.

Fixes #1679

Changes (2/24/26)

reorganized when the table is redrawn so that the page will stop switching after every graduate student selection.
Removed initialized page methods
removed direct event binding allowing handlers to work across multiple pages (allows buttons on page 2 and onward to work)

Changes

Added remove class 'hidden' and redraw table code so that status could go back to senior after being unchecked as graduated

Testing (New Problem Identified - 2/24/26)

-set in database/reset_database.sh from-backup

Click Admin, then 'Graduation Management'
Next you will chose a student (on page two or higher)
With the graduate toggle off (in its white form), click on the student's grad cap check box (their name should disappear)
However, the page you are on should stay the same

Testing (Previous Problem Identified)

-set in database/reset_database.sh from-backup

Click Admin, then 'Graduation Management'
Next you will chose a student, I usually use 'Monica' who is a senior
With the graduate toggle off (in its white form), click on Monicas grad cap check box (her name should disappear)
With the toggle still off, try to search her name in the search bar. You shouldn't be able to find her now that she is Alumni status
Next, switch the toggle on and search up Monica. (She should show up and her status should be Alumni)
Now, with the toggle still on, unclick Monica's grad cap button (She should still be visible since this version of the list includes both graduates and enrolled but now her status should say senior)

… not rsvp and have attended and or have not attended

… counted for two sections

…er details

… manage volunteer table can see ALL the volunteers added to the event

…tails.html

… finished updating waitlisted references for user in the checkbox

…ox is unchecked

app/controllers/admin/volunteers.py

Arohasina

-tested the changes, all work
-ran ./tests/run_tests.sh everything passed

All good on my side. If the second reviewer approves i believe this PR can be merged

bakobagassas

Hey! So for this issue I think there was a confusion. I recreated the testing in development and it seems to be working fine.

From my understanding, the issue should mainly be about the responsiveness of the pages that come after the first page on the graduation management page - not really the logic of the alumni thingy. Here is the description from Trello "The Graduation Management interface only works on the first page of data. Subsequent pages and searched students do not work.".

Also, there are a lot of commits in this PR that are not related to the graduation management page.

…le pages

…or the page. (So it doesn't switch pages after every graduate selection)

app/logic/volunteerSpreadsheet.py

app/controllers/admin/volunteers.py

app/templates/events/volunteerDetails.html

app/logic/participants.py

…everted dictionary enhancement in voluteerdetails.html

…ck to original placement

JohnCox2211

It looks like you've still included changes from your other PR for RSVP language in this PR in volunteerDetails.html.

…play and table isnt functioning completely.

Meatchema · 2026-03-25T19:40:11Z

It looks like you've still included changes from your other PR for RSVP language in this PR in volunteerDetails.html.
Good Afternoon! I was wondering if it is possible for you to highlight the lines that include the changes in volunteerDetails.html. I have tried finding them and comparing them with the base code (using github code viewer comparing my code to our base code) but I have been having trouble finding it.

If not, are you able to identify which variable was maybe not there before that needs to be gotten rid of, etc. ( I am also open to planning a work time in person to be shown this)

JohnCox2211

It looks like you've still included changes from your other PR for RSVP language in this PR in volunteerDetails.html.
Good Afternoon! I was wondering if it is possible for you to highlight the lines that include the changes in volunteerDetails.html. I have tried finding them and comparing them with the base code (using github code viewer comparing my code to our base code) but I have been having trouble finding it.

If not, are you able to identify which variable was maybe not there before that needs to be gotten rid of, etc. ( I am also open to planning a work time in person to be shown this)

These changes don't seem necessary for this PR since they deal with volunteers and RSVP

…nditional to default

Meatchema · 2026-04-02T13:24:25Z

It looks like you've still included changes from your other PR for RSVP language in this PR in volunteerDetails.html.
Good Afternoon! I was wondering if it is possible for you to highlight the lines that include the changes in volunteerDetails.html. I have tried finding them and comparing them with the base code (using github code viewer comparing my code to our base code) but I have been having trouble finding it.

If not, are you able to identify which variable was maybe not there before that needs to be gotten rid of, etc. ( I am also open to planning a work time in person to be shown this)

These changes don't seem necessary for this PR since they deal with volunteers and RSVP

Thanks, I have re-added the missing code and now it seems to show people:

Also, I believe attendedUser and rsvpUser were already there because without it, this is returned:

JohnCox2211

The functionality is all there, though there seems to be some redundant code that I pointed out in my comments.

JohnCox2211 · 2026-04-06T20:57:47Z

app/static/js/graduationManagement.js

+                    row.removeClass('hidden');
                }
+                gradStudentsTable.draw();
+                gradStudentsTable.page(currentPage).draw(false);


Line 152 shouldn't be necessary, you are redrawing the table, putting it on the page, then redrawing it again it seems. You could just remove this line then change the line above it to be:
gradStudentsTable.draw(false)

I have now simplified the last two lines of the above code to be only: gradStudentsTable.draw(false) and verified that it still works properly after.

JohnCox2211 · 2026-04-06T20:58:17Z

app/static/js/graduationManagement.js

-                initializePage()
                msgFlash(`Saved graduation status for ${username}.`, "success", 1000)
                const row = $(`tr[data-username="${username}"]`);
+                var currentPage = gradStudentsTable.page();


If you make the change below, then you shouldn't need the currentPage variable either.

I have now removed this variable and verified that the code still works.

github-actions · 2026-04-07T17:07:10Z

View Code Coverage

Kafui123 · 2026-04-08T21:25:16Z

reviewed this pr and tested it against different edge cases.... looks good to me. @Meatchema, can you please merge the latest changes from development into your branch so I can approve it ? Thanks

Meatchema added 15 commits January 22, 2026 16:17

Added in InvitedUser variable to differentiate between users who were…

11fc7da

… not rsvp and have attended and or have not attended

Merge branch 'development' into issue-1663-change-rsvp-language

7f7db93

Merge branch 'development' into issue-1663-change-rsvp-language

f97f9f3

Merge branch 'development' into issue-1663-change-rsvp-language

11a372e

Fixed the user's Invited label in the table and card

fa303f1

Fixed the entry counter in 'volunteer details'-html printParticipants…

79180c3

… counted for two sections

Removed datetime restriction so that scanned user can show in volunte…

fb6af41

…er details

changed eventVolunteerData to include non-waitlist RSVP's so that the…

12ebcff

… manage volunteer table can see ALL the volunteers added to the event

Removed resourceReader import statement

d977e8a

Merge branch 'development' into issue-1663-change-rsvp-language

0009316

Merge branch 'development' into issue-1663-change-rsvp-language

286cee0

Merge branch 'development' into issue-1663-change-rsvp-language

a3ee57d

I have changed the verbage from waitlist to waitlisted in volunteerDe…

8fb9053

…tails.html

Changed createCheckbox to a dictionary to increase readability. Also,…

2440ebb

… finished updating waitlisted references for user in the checkbox

removed hidden class to show the Senior status after graduate check b…

c42cd9d

…ox is unchecked

Meatchema self-assigned this Feb 19, 2026

Meatchema requested a review from bakobagassas February 19, 2026 14:21

Arohasina self-requested a review February 19, 2026 20:26

Arohasina reviewed Feb 19, 2026

View reviewed changes

app/controllers/admin/volunteers.py Outdated Show resolved Hide resolved

Arohasina reviewed Feb 19, 2026

View reviewed changes

added the laborAttendanceByTerm function

1fe7b84

bakobagassas requested changes Feb 20, 2026

View reviewed changes

Meatchema added 2 commits February 24, 2026 10:28

removed direct event binding allowing handlers to work accross multip…

2680d7b

…le pages

reorganized the code so that the page saves after updating the data f…

f922a9c

…or the page. (So it doesn't switch pages after every graduate selection)

Meatchema requested review from Arohasina, Kafui123 and bakobagassas February 24, 2026 15:44

Meatchema added 3 commits March 6, 2026 14:04

Merge branch 'development' into graduation-management-first-page

2ac2493

Merge branch 'development' into graduation-management-first-page

dda493d

reverted incoming changes to previous changes to make code work again

b6ee7f9

bakobagassas reviewed Mar 10, 2026

View reviewed changes

app/logic/volunteerSpreadsheet.py Outdated Show resolved Hide resolved

app/controllers/admin/volunteers.py Outdated Show resolved Hide resolved

app/templates/events/volunteerDetails.html Outdated Show resolved Hide resolved

app/logic/participants.py Outdated Show resolved Hide resolved

Meatchema added 6 commits March 11, 2026 15:38

Merge branch 'development' into graduation-management-first-page

9a1a508

removed laborAttendancebyTerm function

ed8d721

Resolved: Reverted participants.py this file, reinserted rsvp user, r…

8e66c28

…everted dictionary enhancement in voluteerdetails.html

volunteerdetail.htm dictionary reversion

ca10c2f

removed attendedUser object in volunteer.py and reordered callings ba…

866151a

…ck to original placement

Removed invited checkbox

e8de989

Meatchema requested a review from bakobagassas March 17, 2026 18:49

JohnCox2211 self-requested a review March 19, 2026 18:57

JohnCox2211 requested changes Mar 19, 2026

View reviewed changes

Meatchema added 2 commits March 23, 2026 16:34

Code reversion except grad changes, trying to figure out why card dis…

d1ef839

…play and table isnt functioning completely.

Merge branch 'development' into graduation-management-first-page

c71d2c0

Meatchema requested a review from JohnCox2211 March 25, 2026 19:40

Merge branch 'development' into graduation-management-first-page

e1ec401

JohnCox2211 requested changes Apr 1, 2026

View reviewed changes

Added in missing code: combinedParticpant declaration and set rsvp co…

40c5d07

…nditional to default

Meatchema requested a review from JohnCox2211 April 2, 2026 13:24

Fixed spacing based on images

5ab4f46

JohnCox2211 requested changes Apr 6, 2026

View reviewed changes

remove currentpage variable and the redrawing of the table

175149e

Conversation

Meatchema commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Description

Changes (2/24/26)

Changes

Testing (New Problem Identified - 2/24/26)

Testing (Previous Problem Identified)

Uh oh!

Uh oh!

Arohasina left a comment

Choose a reason for hiding this comment

Uh oh!

bakobagassas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JohnCox2211 left a comment

Choose a reason for hiding this comment

Uh oh!

Meatchema commented Mar 25, 2026

Uh oh!

JohnCox2211 left a comment

Choose a reason for hiding this comment

Uh oh!

Meatchema commented Apr 2, 2026

Uh oh!

JohnCox2211 left a comment

Choose a reason for hiding this comment

Uh oh!

JohnCox2211 Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Meatchema Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

JohnCox2211 Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Meatchema Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

Kafui123 commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Meatchema commented Feb 19, 2026 •

edited

Loading

bakobagassas left a comment •

edited

Loading

JohnCox2211 Apr 6, 2026 •

edited

Loading

JohnCox2211 Apr 6, 2026 •

edited

Loading

Kafui123 commented Apr 8, 2026 •

edited

Loading