Skip to content

[DoNotMerge] Add azure-resourcemanager-fileshares SDK package (1.0.0-beta.1, api-version 2026-06-01)#48976

Open
ankushbindlish2 wants to merge 1 commit intoAzure:mainfrom
ankushbindlish2:fileshares-GA-apiversion-java
Open

[DoNotMerge] Add azure-resourcemanager-fileshares SDK package (1.0.0-beta.1, api-version 2026-06-01)#48976
ankushbindlish2 wants to merge 1 commit intoAzure:mainfrom
ankushbindlish2:fileshares-GA-apiversion-java

Conversation

@ankushbindlish2
Copy link
Copy Markdown
Member

@ankushbindlish2 ankushbindlish2 commented Apr 29, 2026

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings April 29, 2026 13:44
@ankushbindlish2 ankushbindlish2 changed the title [[DoNotMerge] Add azure-resourcemanager-fileshares SDK package (1.0.0-beta.1, api-version 2026-06-01) [DoNotMerge] Add azure-resourcemanager-fileshares SDK package (1.0.0-beta.1, api-version 2026-06-01) Apr 29, 2026
@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Apr 29, 2026
Copilot AI reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Fileshares service directory under sdk/ and introduces the azure-resourcemanager-fileshares management-plane SDK module (v1.0.0-beta.1, targeting api-version 2026-06-01) with generated sources, tests, samples, and CI wiring.

Changes:

  • Adds sdk/fileshares aggregator module and wires it into the repo root pom.xml.
  • Introduces azure-resourcemanager-fileshares Maven module with generated client/models/impl, samples, tests, and native-image configs.
  • Adds service-directory CI pipeline (sdk/fileshares/ci.yml) and a module CHANGELOG.md.

Reviewed changes

Copilot reviewed 113 out of 188 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sdk/fileshares/pom.xml Service-directory aggregator POM for the new fileshares SDK area.
sdk/fileshares/ci.yml CI pipeline definition for building/testing the fileshares service directory.
sdk/fileshares/azure-resourcemanager-fileshares/tsp-location.yaml TypeSpec/spec source pointer metadata for regeneration.
sdk/fileshares/azure-resourcemanager-fileshares/pom.xml Maven module POM for the new management-plane package.
sdk/fileshares/azure-resourcemanager-fileshares/CHANGELOG.md Initial release notes for 1.0.0-beta.1.
pom.xml Adds sdk/fileshares as a top-level Maven module.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/module-info.java JPMS module definition for com.azure.resourcemanager.fileshares.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/resources/azure-resourcemanager-fileshares.properties Module version properties file.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/resources/META-INF/native-image/com.azure.resourcemanager/azure-resourcemanager-fileshares/reflect-config.json Native-image reflection configuration (empty).
sdk/fileshares/azure-resourcemanager-fileshares/src/main/resources/META-INF/native-image/com.azure.resourcemanager/azure-resourcemanager-fileshares/proxy-config.json Native-image proxy configuration for service interfaces.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/package-info.java Package-level docs for the public entry package.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/package-info.java Package-level docs for public models.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/ShareRootSquash.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/Redundancy.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/PublicNetworkAccess.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/PublicAccessProperties.java Generated model with JSON serialization/deserialization.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/Protocol.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/PrivateLinkResources.java Public resource-collection surface for private link resources.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/PrivateLinkResourceProperties.java Generated immutable model for private link resource properties.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/PrivateLinkResource.java Public immutable resource interface for private link resources.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/PrivateEndpointServiceConnectionStatus.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/PrivateEndpointConnectionProvisioningState.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/PrivateEndpoint.java Generated immutable model for private endpoint.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/Origin.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/Operations.java Public resource-collection surface for provider operations.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/Operation.java Public immutable operation interface.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/MediaTier.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/LiveSharesUsageData.java Generated immutable model for usage data.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/InformationalOperations.java Public surface for informational endpoints (usage/limits/recommendations).
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareUsageDataResponse.java Public response interface for usage data.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareUsageDataOutput.java Generated immutable model for usage data output.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareSnapshotUpdateProperties.java Generated update properties model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareSnapshotUpdate.java Generated update request model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareProvisioningState.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareProvisioningRecommendationResponse.java Public response interface for provisioning recommendations.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareProvisioningRecommendationRequest.java Generated request model for provisioning recommendations.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareProvisioningRecommendationInput.java Generated input model for provisioning recommendations.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareLimitsResponse.java Public response interface for limits.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/FileShareLimitsOutput.java Generated immutable model for limits output.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/EncryptionInTransitRequired.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/CheckNameAvailabilityResponse.java Public response interface for name-availability checks.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/CheckNameAvailabilityReason.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/ActionType.java Generated expandable enum model.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/package-info.java Package docs for implementation namespace.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/models/PrivateLinkResourceListResult.java Internal pageable result model for private link resources.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/models/PrivateEndpointConnectionListResult.java Internal pageable result model for private endpoint connections.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/models/OperationListResult.java Internal pageable result model for operations list.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/models/FileShareSnapshotListResult.java Internal pageable result model for snapshot list.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/models/FileShareListResult.java Internal pageable result model for file share list.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/PrivateLinkResourcesImpl.java Implementation wiring for PrivateLinkResources.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/PrivateLinkResourceImpl.java Wrapper implementation for PrivateLinkResource.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/PrivateEndpointConnectionImpl.java Wrapper + definition implementation for private endpoint connections.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/OperationsImpl.java Implementation wiring for Operations.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/OperationImpl.java Wrapper implementation for Operation.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/InformationalOperationsImpl.java Implementation wiring for informational operations.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/FileShareUsageDataResponseImpl.java Wrapper implementation for usage data response.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/FileShareProvisioningRecommendationResponseImpl.java Wrapper implementation for recommendation response.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/FileShareLimitsResponseImpl.java Wrapper implementation for limits response.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/implementation/CheckNameAvailabilityResponseImpl.java Wrapper implementation for name availability response.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/fluent/package-info.java Package docs for fluent client namespace.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/fluent/models/package-info.java Package docs for fluent inner models.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/fluent/models/FileShareUsageDataResponseInner.java Generated inner response model for usage data.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/fluent/models/FileShareProvisioningRecommendationResponseInner.java Generated inner response model for recommendations.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/fluent/models/FileShareLimitsResponseInner.java Generated inner response model for limits.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/fluent/OperationsClient.java Fluent operations client interface.
sdk/fileshares/azure-resourcemanager-fileshares/src/main/java/com/azure/resourcemanager/fileshares/fluent/FileSharesManagementClient.java Fluent service client interface.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/PrivateLinkResourcesListSamples.java Generated usage sample for listing private link resources.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/PrivateLinkResourcesGetSamples.java Generated usage sample for getting a private link resource.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionsListByFileShareSamples.java Generated usage sample for listing private endpoint connections.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionsGetSamples.java Generated usage sample for getting a private endpoint connection.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionsDeleteSamples.java Generated usage sample for deleting a private endpoint connection.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionsCreateSamples.java Generated usage sample for creating a private endpoint connection.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/OperationsListSamples.java Generated usage sample for listing provider operations.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/InformationalOperationsGetUsageDataSamples.java Generated usage sample for usage-data endpoint.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/InformationalOperationsGetProvisioningRecommendationSamples.java Generated usage sample for recommendations endpoint.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/InformationalOperationsGetLimitsSamples.java Generated usage sample for limits endpoint.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileSharesUpdateSamples.java Generated usage sample for updating a file share.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileSharesListSamples.java Generated usage sample for listing file shares in subscription.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileSharesListByResourceGroupSamples.java Generated usage sample for listing file shares by RG.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileSharesGetByResourceGroupSamples.java Generated usage sample for get-by-RG.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileSharesDeleteSamples.java Generated usage sample for deleting a file share.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileSharesCreateOrUpdateSamples.java Generated usage sample for create/update.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileSharesCheckNameAvailabilitySamples.java Generated usage sample for name availability.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotsUpdateFileShareSnapshotSamples.java Generated usage sample for updating a snapshot.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotsListByFileShareSamples.java Generated usage sample for listing snapshots.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotsGetFileShareSnapshotSamples.java Generated usage sample for getting a snapshot.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotsDeleteFileShareSnapshotSamples.java Generated usage sample for deleting a snapshot.
sdk/fileshares/azure-resourcemanager-fileshares/src/samples/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotsCreateOrUpdateFileShareSnapshotSamples.java Generated usage sample for create/update snapshot.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PublicAccessPropertiesTests.java Generated JSON (de)serialization tests for PublicAccessProperties.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateLinkServiceConnectionStateTests.java Generated JSON (de)serialization tests for PrivateLinkServiceConnectionState.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateLinkResourcesListMockTests.java Generated mocked-wire test for listing private link resources.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateLinkResourcesGetWithResponseMockTests.java Generated mocked-wire test for get-with-response.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateLinkResourcePropertiesTests.java Generated JSON deserialization test for PrivateLinkResourceProperties.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateLinkResourceListResultTests.java Generated deserialization tests for pageable list result.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateLinkResourceInnerTests.java Generated deserialization tests for inner model.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointTests.java Generated JSON (de)serialization tests for PrivateEndpoint.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionsListByFileShareMockTests.java Generated mocked-wire test for listing private endpoint connections.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionsGetWithResponseMockTests.java Generated mocked-wire test for get-with-response.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionsDeleteMockTests.java Generated mocked-wire test for delete.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionsCreateMockTests.java Generated mocked-wire test for create.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionPropertiesTests.java Generated JSON (de)serialization tests for connection properties.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionListResultTests.java Generated deserialization tests for pageable result.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/PrivateEndpointConnectionInnerTests.java Generated JSON (de)serialization tests for inner model.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/OperationsListMockTests.java Generated mocked-wire test for operations list.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/OperationListResultTests.java Generated deserialization tests for operations list result.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/OperationInnerTests.java Generated deserialization tests for inner operation.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/OperationDisplayTests.java Generated deserialization tests for operation display.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/NfsProtocolPropertiesTests.java Generated JSON (de)serialization tests for NFS properties.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/LiveSharesUsageDataTests.java Generated deserialization tests for usage model.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/InformationalOperationsGetUsageDataWithResponseMockTests.java Generated mocked-wire test for usage endpoint.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/InformationalOperationsGetProvisioningRecommendationWithResponseMockTests.java Generated mocked-wire test for recommendation endpoint.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/InformationalOperationsGetLimitsWithResponseMockTests.java Generated mocked-wire test for limits endpoint.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileSharesCheckNameAvailabilityWithResponseMockTests.java Generated mocked-wire test for name availability endpoint.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareUsageDataResponseInnerTests.java Generated deserialization tests for inner usage response.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareUsageDataOutputTests.java Generated deserialization tests for usage output.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareUpdatePropertiesTests.java Generated JSON (de)serialization tests for update properties.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotsListByFileShareMockTests.java Generated mocked-wire test for snapshot listing.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotsGetFileShareSnapshotWithResponseMockTests.java Generated mocked-wire test for snapshot get.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotUpdateTests.java Generated JSON (de)serialization tests for snapshot update.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotUpdatePropertiesTests.java Generated JSON (de)serialization tests for snapshot update properties.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotPropertiesTests.java Generated JSON (de)serialization tests for snapshot properties.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotListResultTests.java Generated deserialization tests for snapshot list result.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareSnapshotInnerTests.java Generated JSON (de)serialization tests for snapshot inner model.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareProvisioningRecommendationResponseInnerTests.java Generated deserialization tests for recommendation response inner.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareProvisioningRecommendationRequestTests.java Generated JSON (de)serialization tests for recommendation request.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareProvisioningRecommendationOutputTests.java Generated deserialization tests for recommendation output.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareProvisioningRecommendationInputTests.java Generated JSON (de)serialization tests for recommendation input.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareProvisioningConstantsTests.java Generated deserialization tests for provisioning constants.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareLimitsTests.java Generated deserialization tests for limits model.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareLimitsResponseInnerTests.java Generated deserialization tests for limits response inner.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/FileShareLimitsOutputTests.java Generated deserialization tests for limits output.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/CheckNameAvailabilityResponseInnerTests.java Generated deserialization tests for check-name response inner.
sdk/fileshares/azure-resourcemanager-fileshares/src/test/java/com/azure/resourcemanager/fileshares/generated/CheckNameAvailabilityRequestTests.java Generated JSON (de)serialization tests for check-name request.

Comment thread sdk/fileshares/azure-resourcemanager-fileshares/tsp-location.yaml
Comment on lines +1 to +4
directory: specification/fileshares/resource-manager/Microsoft.FileShares/FileShares
commit: 10936f3580808a031acfadffe8eae35aa29a9b5d
repo: ankushbindlish2/azure-rest-api-specs
additionalDirectories:
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsp-location.yaml points at a personal fork (repo: ankushbindlish2/azure-rest-api-specs). In this repo, tsp-location.yaml files consistently reference Azure/azure-rest-api-specs, and using a fork will break downstream automation that expects the canonical specs repo. Update repo to Azure/azure-rest-api-specs (and keep the commit SHA aligned with that repo).

Copilot uses AI. Check for mistakes.
Comment thread ...src/main/java/com/azure/resourcemanager/fileshares/models/PrivateLinkResourceProperties.java
Comment on lines +71 to +75
@Override
public JsonWriter toJson(JsonWriter jsonWriter) throws IOException {
jsonWriter.writeStartObject();
return jsonWriter.writeEndObject();
}
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PrivateLinkResourceProperties has populated fields (groupId, requiredMembers, requiredZoneNames) but toJson serializes an empty object. This breaks round-trip serialization (e.g., BinaryData.fromObject(...)) and can lead to silent data loss if the model is ever serialized (logging, caching, user code, etc.). Please write these fields in toJson to match what fromJson reads (and omit nulls as appropriate).

Copilot uses AI. Check for mistakes.
Comment thread ...er-fileshares/src/main/java/com/azure/resourcemanager/fileshares/models/PrivateEndpoint.java
Comment on lines +42 to +46
@Override
public JsonWriter toJson(JsonWriter jsonWriter) throws IOException {
jsonWriter.writeStartObject();
return jsonWriter.writeEndObject();
}
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PrivateEndpoint reads an id field in fromJson, but toJson writes an empty object. This means serializing an instance (e.g., via BinaryData.fromObject) will drop id, which is inconsistent with the rest of the models in this package and can cause surprising behavior for consumers. Update toJson to write the id field (when non-null) so serialization matches deserialization.

Copilot uses AI. Check for mistakes.
Comment thread pom.xml
<module>sdk/extendedlocation</module>
<module>sdk/fabric</module>
<module>sdk/face</module>
<module>sdk/fileshares</module>
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is still the autogenerated template (it asks to “Please add an informative description…” and the checklist is unchecked). Before merging, update the PR description to summarize the change (new azure-resourcemanager-fileshares package), link the spec source PR/commit, and include verification steps (build/tests).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft weidongxu-microsoft is a code owner

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankushbindlish2