Idickers/2026 04 01 java sdk fix v2#48964
Merged
idickerson7 merged 4 commits intomainfrom Apr 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the azure-search-documents Java SDK (likely via TypeSpec regeneration) to align with newer Search 2026-04-01 surface changes, including KnowledgeBase retrieval API shape updates and new activity record modeling.
Changes:
- Bumps the
tsp-location.yamlspec commit reference used for generation. - Updates KnowledgeBase retrieval APIs/samples and adds a new
modelWebSummarizationactivity record subtype. - Removes
KnowledgeSourceIngestionPermissionOptionand the related ingestion-parameters property + test coverage.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/search/azure-search-documents/tsp-location.yaml | Updates the referenced swagger/spec commit for generation. |
| sdk/search/azure-search-documents/src/test/java/com/azure/search/documents/KnowledgeSourceTests.java | Removes enum import and an enum-value test tied to removed model. |
| sdk/search/azure-search-documents/src/samples/java/com/azure/search/documents/codesnippets/KnowledgeBaseRetrievalJavaDocSnippets.java | Updates snippet tags and switches retrieval calls to the new retrieve(options) shape. |
| sdk/search/azure-search-documents/src/main/resources/META-INF/azure-search-documents_metadata.json | Regenerated metadata reflecting new/removed model types. |
| sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/KnowledgeBaseModelWebSummarizationActivityRecord.java | Adds new activity record model for modelWebSummarization. |
| sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeSourceIngestionParameters.java | Removes ingestionPermissionOptions property and JSON serialization/deserialization. |
| sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseAgenticReasoningActivityRecord.java | Adjusts JSON deserialization and adds duplicated error/elapsedMs storage + overrides. |
| sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseActivityRecordType.java | Adds MODEL_WEB_SUMMARIZATION discriminator value. |
| sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseActivityRecord.java | Adds discriminator routing for modelWebSummarization. |
| sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/KnowledgeBaseRetrievalClient.java | Removes per-call knowledgeBaseName overloads; retrieval now uses builder-configured KB name. |
| sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/KnowledgeBaseRetrievalAsyncClient.java | Same as sync client, for async API. |
| sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/KnowledgeSourceIngestionPermissionOption.java | Removes the permission option model type. |
| sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/KnowledgeBaseRetrievalClientImpl.java | Updates docstring schema to mention modelWebSummarization activity type. |
alzimmermsft
approved these changes
Apr 29, 2026
efrainretana
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines