Skip to content

Idickers/2026 04 01 java sdk fix v2#48964

Merged
idickerson7 merged 4 commits intomainfrom
idickers/2026-04-01-java-sdk-fix-v2
Apr 29, 2026
Merged

Idickers/2026 04 01 java sdk fix v2#48964
idickerson7 merged 4 commits intomainfrom
idickers/2026-04-01-java-sdk-fix-v2

Conversation

@idickerson7
Copy link
Copy Markdown
Member

@idickerson7 idickerson7 commented Apr 28, 2026

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings April 28, 2026 21:47
@idickerson7 idickerson7 requested review from a team as code owners April 28, 2026 21:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the azure-search-documents Java SDK (likely via TypeSpec regeneration) to align with newer Search 2026-04-01 surface changes, including KnowledgeBase retrieval API shape updates and new activity record modeling.

Changes:

  • Bumps the tsp-location.yaml spec commit reference used for generation.
  • Updates KnowledgeBase retrieval APIs/samples and adds a new modelWebSummarization activity record subtype.
  • Removes KnowledgeSourceIngestionPermissionOption and the related ingestion-parameters property + test coverage.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
sdk/search/azure-search-documents/tsp-location.yaml Updates the referenced swagger/spec commit for generation.
sdk/search/azure-search-documents/src/test/java/com/azure/search/documents/KnowledgeSourceTests.java Removes enum import and an enum-value test tied to removed model.
sdk/search/azure-search-documents/src/samples/java/com/azure/search/documents/codesnippets/KnowledgeBaseRetrievalJavaDocSnippets.java Updates snippet tags and switches retrieval calls to the new retrieve(options) shape.
sdk/search/azure-search-documents/src/main/resources/META-INF/azure-search-documents_metadata.json Regenerated metadata reflecting new/removed model types.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/KnowledgeBaseModelWebSummarizationActivityRecord.java Adds new activity record model for modelWebSummarization.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeSourceIngestionParameters.java Removes ingestionPermissionOptions property and JSON serialization/deserialization.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseAgenticReasoningActivityRecord.java Adjusts JSON deserialization and adds duplicated error/elapsedMs storage + overrides.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseActivityRecordType.java Adds MODEL_WEB_SUMMARIZATION discriminator value.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseActivityRecord.java Adds discriminator routing for modelWebSummarization.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/KnowledgeBaseRetrievalClient.java Removes per-call knowledgeBaseName overloads; retrieval now uses builder-configured KB name.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/KnowledgeBaseRetrievalAsyncClient.java Same as sync client, for async API.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/KnowledgeSourceIngestionPermissionOption.java Removes the permission option model type.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/KnowledgeBaseRetrievalClientImpl.java Updates docstring schema to mention modelWebSummarization activity type.

Comment thread sdk/search/azure-search-documents/tsp-location.yaml Outdated
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure SDK for Search Apr 29, 2026
@idickerson7 idickerson7 merged commit c195108 into main Apr 29, 2026
17 checks passed
@idickerson7 idickerson7 deleted the idickers/2026-04-01-java-sdk-fix-v2 branch April 29, 2026 17:40
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure SDK for Search Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants