Skip to content

[POSGRESQL] BREAKING CHANGE az postgres flexible-server create | update: Remove -high-availability for preferred argument --zonal-resiliency#33300

Open
nasc17 wants to merge 3 commits intoAzure:devfrom
nasc17:nasc/removeHAargumentBreakingChange
Open

[POSGRESQL] BREAKING CHANGE az postgres flexible-server create | update: Remove -high-availability for preferred argument --zonal-resiliency#33300
nasc17 wants to merge 3 commits intoAzure:devfrom
nasc17:nasc/removeHAargumentBreakingChange

Conversation

@nasc17
Copy link
Copy Markdown
Member

@nasc17 nasc17 commented Apr 30, 2026

Related command
az postgres flexible-server create
az postgres flexible-server update

Description
We are switching out high availability argument name for zonal resiliency in alignment with documentation across other PostgreSQL tools.

Testing Guide
Manual

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

nasc17 and others added 2 commits April 30, 2026 01:14
Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 30, 2026 12:28
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@github-actions
Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 30, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PostgreSQL Flexible Server create and update command surface area to replace the --high-availability argument with --zonal-resiliency, aligning the CLI with naming used elsewhere in PostgreSQL tooling/documentation.

Changes:

  • Removes --high-availability parameter wiring and validation, and uses --zonal-resiliency as the controlling argument.
  • Updates flexible-server create/update implementations to derive HA mode from --zonal-resiliency.
  • Updates validator-focused tests to use --zonal-resiliency.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/azure-cli/azure/cli/command_modules/postgresql/utils/validators.py Drops the --high-availability validator path and validates zonal resiliency instead.
src/azure-cli/azure/cli/command_modules/postgresql/commands/custom_commands.py Removes high_availability args from create/update entrypoints and maps zonal resiliency to HA mode.
src/azure-cli/azure/cli/command_modules/postgresql/_params.py Removes --high-availability argument definition; retains/introduces --zonal-resiliency.
src/azure-cli/azure/cli/command_modules/postgresql/_breaking_change.py Removes the previous argument deprecation/redirect registration for --high-availability.
src/azure-cli/azure/cli/command_modules/postgresql/tests/latest/test_postgres_flexible_commands.py Updates validator tests to use --zonal-resiliency.
Comments suppressed due to low confidence (1)

src/azure-cli/azure/cli/command_modules/postgresql/utils/validators.py:359

  • The error message raised for Burstable tier uses "High availability is not supported..." but the public-facing argument being validated here is --zonal-resiliency. Updating the wording to reference zonal resiliency (and optionally parenthetically mention HA) will make the CLI guidance consistent with the new parameter name.
        if tier.lower() == 'burstable':
            raise ArgumentUsageError('High availability is not supported for the Burstable tier.')
        if single_az and allow_same_zone is False:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/azure-cli/azure/cli/command_modules/postgresql/_params.py
Comment thread src/azure-cli/azure/cli/command_modules/postgresql/utils/validators.py Outdated
Copy link
Copy Markdown
Member

@nachoalonsoportillo nachoalonsoportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than addressing the issues identified by Copilot, it looks good to me.

@nasc17 nasc17 changed the title [POSGRESQL] BREAKING CHANGE az postgres flexible-server create | update: Remove -high-availability for perferred argument --zonal-resiliency [POSGRESQL] BREAKING CHANGE az postgres flexible-server create | update: Remove -high-availability for preferred argument --zonal-resiliency Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants