{AKS} az aks create/update: Update container network logs error message to mention portal enablement of ACNS#33299
Closed
carlotaarvela wants to merge 2 commits intoAzure:devfrom
Closed
Conversation
carlotaarvela
requested review from
FumingZhang,
NoriZC,
teresaritorto and
yanzhudd
as code owners
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
elvazhu521,
jsntcy,
wangzelin007 and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
microsoft-github-policy-service
Bot
added
Portal
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the AKS managed cluster decorator validation message shown when users enable container network logs (CNL) without meeting prerequisites, expanding the guidance beyond just the CLI flag.
Changes:
- Updated the
InvalidArgumentValueErrormessage for CNL prerequisite validation to mention enabling ACNS via portal or--enable-acns. - Reworded the message to be more descriptive about required services/addons.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2771
to
+2772
| "Container network logs require Advanced Container Networking Services to be enabled. " | ||
| "Activate this service through the portal or use the CLI with --enable-acns flag. " |
There was a problem hiding this comment.
The new error message introduces the term "Advanced Container Networking Services" for ACNS, but the rest of this command module’s help/params text expands ACNS as "Azure Container Networking Solution (ACNS)". To avoid user confusion, please align this message’s terminology with the existing ACNS naming (or update the other user-facing strings consistently in the same PR). Also consider saying "Azure portal" (consistent with other help strings) instead of the generic "portal".
Suggested change
| "Container network logs require Advanced Container Networking Services to be enabled. " | |
| "Activate this service through the portal or use the CLI with --enable-acns flag. " | |
| "Container network logs require Azure Container Networking Solution (ACNS) to be enabled. " | |
| "Activate this service through the Azure portal or use the CLI with --enable-acns flag. " |
carlotaarvela
changed the title
carlotaarvela
changed the title
az aks create/update: Update container network logs error message to mention portal enablement of ACNS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks create,az aks updateDescription
Updated the error message shown when a user tries to enable container network logs (CNL) without having Advanced Container Networking Services (ACNS) enabled. Previously, the message only referenced the
--enable-acnsCLI flag. Since ACNS can now also be enabled through the Azure portal, the error message has been updated to inform users of both options.New message:
Testing Guide
# Attempt to enable CNL without ACNS — should show updated error message az aks create -g myRG -n myCluster --network-plugin azure --network-plugin-mode overlay --network-dataplane cilium --enable-addons monitoring --enable-container-network-logsHistory Notes
[AKS]
az aks create/update: Update container network logs error message to mention portal enablement of ACNSThe PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.