Conversation
️✔️AzureCLI-FullTest
|
|
Hi @FumingZhang, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
Bot
added
Auto-Assign
There was a problem hiding this comment.
Pull request overview
Updates AKS ownership/routing metadata so PRs and issues related to az aks are routed to the intended maintainers.
Changes:
- Add
@elvazhu521as a code owner for the AKS (implemented incommand_modules/acs) area. - Add
elvazhu521to AKS-related mention routing for Service Attention labels. - Update AKS/ACS/openshift PR auto-reviewer routing (including removing
zhoxing-msfrom that specific rule).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/policies/resourceManagement.yml |
Updates issue/PR routing rules to include elvazhu521 (and adjusts AKS PR reviewer/assignee list). |
.github/CODEOWNERS |
Adds @elvazhu521 as code owner for command_modules/acs (AKS-related commands). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| then: | ||
| - requestReview: | ||
| reviewer: zhoxing-ms | ||
| - requestReview: | ||
| reviewer: yanzhudd | ||
| - assignTo: | ||
| users: | ||
| - zhoxing-ms | ||
| - yanzhudd |
There was a problem hiding this comment.
This hunk not only adds elvazhu521 as a reviewer, it also removes zhoxing-ms from both requestReview and assignTo for AKS/ACS/openshift PR routing. If the intent is only to add a new code owner/reviewer, please restore zhoxing-ms; otherwise, please update the PR description to reflect that ownership/routing is being changed (removing an existing reviewer/assignee).
Related command
Description
Add Elva as code owner of aks command group.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.