Skip to content

[Storage] az storage account create/update: Update description for tls 1.3 being not yet available, remove breaking change warning to deprecate tls1.0, tls1.1 #33243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinhzy merged 1 commit into from
Apr 24, 2026
+2 −14
Merged

[Storage] az storage account create/update: Update description for tls 1.3 being not yet available, remove breaking change warning to deprecate tls1.0, tls1.1 #33243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/azure-cli/azure/cli/command_modules/storage/_breaking_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,3 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

from azure.cli.core.breaking_change import register_other_breaking_change

# --min-tls-version removing version 1.0 1.1
register_other_breaking_change('storage account create',
message='The --min-tls-version argument values TLS1_0 and TLS1_1 have been retired on'
' 2026/02/03 and will be removed on 2026/03/03.')
register_other_breaking_change('storage account update',
message='The --min-tls-version argument values TLS1_0 and TLS1_1 have been retired on'
' 2026/02/03 and will be removed on 2026/03/03.')
6 changes: 2 additions & 4 deletions src/azure-cli/azure/cli/command_modules/storage/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,7 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem
'public access setting for a container is required to enable anonymous access.')
c.argument('min_tls_version', arg_type=get_enum_type(t_tls_version),
help='The minimum TLS version to be permitted on requests to storage. '
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --min-tls-version help text no longer matches the command behavior: storage account create/update still accepts TLS1_0/TLS1_1 but silently coerces them to TLS1_2 (with a warning) in storage/operations/account.py. Consider updating this help to explicitly state that TLS1_0 and TLS1_1 are retired and will be treated as TLS1_2, so users aren’t surprised by the resulting value.

Suggested change
help='The minimum TLS version to be permitted on requests to storage. '
help='The minimum TLS version to be permitted on requests to storage. '
'TLS1_0 and TLS1_1 are retired and will be treated as TLS1_2. '

Copilot uses AI. Check for mistakes.
' Values TLS1_0 and TLS1_1 have been retired on 2026/02/03 and will be removed on 2026/03/03.'
' Microsoft recommends setting MinimumTlsVersion to TLS1_2')
'TLS1_3 is not yet supported. Microsoft recommends setting MinimumTlsVersion to TLS1_2.')
c.argument('allow_shared_key_access', allow_shared_key_access_type)
c.argument('edge_zone', edge_zone_type)
c.argument('identity_type', arg_type=get_enum_type(t_identity_type), arg_group='Identity',
Expand Down Expand Up @@ -509,8 +508,7 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem
'public access setting for a container is required to enable anonymous access.')
c.argument('min_tls_version', arg_type=get_enum_type(t_tls_version),
help='The minimum TLS version to be permitted on requests to storage. '
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as storage account create: this --min-tls-version help text doesn’t mention that TLS1_0 and TLS1_1 inputs are coerced to TLS1_2 by the implementation (with a warning) in storage/operations/account.py. Please reflect that in the help so the CLI behavior is transparent.

Suggested change
help='The minimum TLS version to be permitted on requests to storage. '
help='The minimum TLS version to be permitted on requests to storage. '
'TLS1_0 and TLS1_1 inputs are coerced to TLS1_2 with a warning. '

Copilot uses AI. Check for mistakes.
' Values TLS1_0 and TLS1_1 have been retired on 2026/02/03 and will be removed on 2026/03/03.'
' Microsoft recommends setting MinimumTlsVersion to TLS1_2')
'TLS1_3 is not yet supported. Microsoft recommends setting MinimumTlsVersion to TLS1_2.')
c.argument('allow_shared_key_access', allow_shared_key_access_type)
c.argument('identity_type', arg_type=get_enum_type(t_identity_type), arg_group='Identity',
help='The identity type.')
Expand Down
Loading