Conversation
️✔️AzureCLI-FullTest
|
|
Hi @huiii99, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
jsntcy,
kairu-ms and
yonzhan
huiii99
changed the title
az network route-table: Add parameters --disable-peering-routeaz network route-table create/update: Add parameters --disable-peering-route
huiii99
changed the title
az network route-table create/update: Add parameters --disable-peering-routeaz network route-table create/update: Add parameters --disable-peering-route to support disable peering route
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Network route-table commands to expose the new disablePeeringRoute property (API version 2025-07-01) and adds a scenario test to validate create/update/show/list behavior for the new setting.
Changes:
- Adds a new scenario test for
--disable-peering-routeonaz network route-table create/update, and validates thedisablePeeringRoutefield in show/list output. - Updates generated AAZ route-table command implementations (show/wait/delete) to use API version
2025-07-01and updated read schemas that includedisablePeeringRoute. - Adjusts an existing route-table list test invocation to include
-g/--resource-group.
Reviewed changes
Copilot reviewed 2 out of 9 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py |
Adds a new route-table disable-peering-route scenario test and tweaks an existing list call. |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/route_table/_wait.py |
Bumps API version and updates the wait GET schema to the regenerated “common_*” read schema (includes disablePeeringRoute). |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/route_table/_show.py |
Bumps API version and updates the show GET schema to the regenerated “common_*” read schema (includes disablePeeringRoute). |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/route_table/_delete.py |
Bumps API version used by delete to 2025-07-01. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
necusjz
changed the title
az network route-table create/update: Add parameters --disable-peering-route to support disable peering routeaz network route-table create/update: Add --disable-peering-route to support disable peering route
necusjz
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network route-tableDescription
aaz Azure/aaz#986
resolve #32892
Add support for the new disablePeeringRoute property in Route Tables.
Testing Guide
azdev test test_network_route_table_disable_peering_routeHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.