Skip to content

Add Microsoft.Maintenance ScheduledEvents List acknowledge command#9835

Open
rbandi124 wants to merge 2 commits intoAzure:mainfrom
rbandi124:dev/rbandi/addsebatching
Open

Add Microsoft.Maintenance ScheduledEvents List acknowledge command#9835
rbandi124 wants to merge 2 commits intoAzure:mainfrom
rbandi124:dev/rbandi/addsebatching

Conversation

@rbandi124
Copy link
Copy Markdown
Contributor

@rbandi124 rbandi124 commented Apr 29, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings April 29, 2026 18:55
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Apr 29, 2026

❌Azure CLI Extensions Breaking Change Test
❌maintenance
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove maintenance scheduledevent sub group maintenance scheduledevent removed please confirm sub group maintenance scheduledevent removed
⚠️ 1011 - SubgroupAdd maintenance scheduledevents sub group maintenance scheduledevents added

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @rbandi124,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 29, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

Hi @rbandi124

Release Suggestions

Module: maintenance

  • Please log updates into to src/maintenance/HISTORY.rst
  • Update VERSION to 2.0.0b1 in src/maintenance/setup.py

Notes

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds new Microsoft.Maintenance ScheduledEvents “list acknowledge” command support and updates scenario tests/metadata to align with the new ScheduledEvents surface.

Changes:

  • Introduces az maintenance scheduledevents list acknowledge AAZ command implementation.
  • Renames ScheduledEvent command group/command/parameter to pluralized scheduledevents and updates scenario tests accordingly.
  • Updates test resources/locations and bumps extension minimum CLI core version.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/maintenance/azext_maintenance/tests/latest/test_maintenance_scenario.py Updates scenario setup (location/SKU/IP) and adds coverage for new scheduledevents list acknowledge.
src/maintenance/azext_maintenance/azext_metadata.json Raises min CLI core version required by the extension.
src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevents/list/_acknowledge.py Adds AAZ command for acknowledging a list of ScheduledEvents IDs.
src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevents/list/init.py Exposes the new scheduledevents list command group and command module.
src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevents/list/__cmd_group.py Registers the maintenance scheduledevents list command group.
src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevent/_acknowledge.py Renames single-event acknowledge command and updates API version/argument name.
src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevent/__cmd_group.py Renames the command group from scheduledevent to scheduledevents.

Comment on lines +21 to +25
az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachinesScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value []
az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}"

:example: Acknowledge list of ScheduledEvents on AvailabilitySets
az maintenance scheduledvents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets"--resource-name {AvSetname} --value []
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help examples contain command/argument typos that will mislead users: virtualMachinesScaleSets should be virtualMachineScaleSets, and scheduledvents should be scheduledevents (also missing a space before --resource-name in the availability set example). Please correct these example strings.

Suggested change
az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachinesScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value []
az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}"
:example: Acknowledge list of ScheduledEvents on AvailabilitySets
az maintenance scheduledvents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets"--resource-name {AvSetname} --value []
az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachineScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value []
az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}"
:example: Acknowledge list of ScheduledEvents on AvailabilitySets
az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets" --resource-name {AvSetname} --value []

Copilot uses AI. Check for mistakes.
Comment on lines +21 to +25
az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachinesScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value []
az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}"

:example: Acknowledge list of ScheduledEvents on AvailabilitySets
az maintenance scheduledvents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets"--resource-name {AvSetname} --value []
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help examples contain command/argument typos that will mislead users: virtualMachinesScaleSets should be virtualMachineScaleSets, and scheduledvents should be scheduledevents (also missing a space before --resource-name in the availability set example). Please correct these example strings.

Suggested change
az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachinesScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value []
az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}"
:example: Acknowledge list of ScheduledEvents on AvailabilitySets
az maintenance scheduledvents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets"--resource-name {AvSetname} --value []
az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachineScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value []
az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}"
:example: Acknowledge list of ScheduledEvents on AvailabilitySets
az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets" --resource-name {AvSetname} --value []

Copilot uses AI. Check for mistakes.
Comment thread src/maintenance/azext_maintenance/tests/latest/test_maintenance_scenario.py Outdated
Comment thread src/maintenance/azext_maintenance/tests/latest/test_maintenance_scenario.py Outdated
@yonzhan yonzhan requested a review from necusjz April 29, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants