Add Microsoft.Maintenance ScheduledEvents List acknowledge command#9835
Add Microsoft.Maintenance ScheduledEvents List acknowledge command#9835rbandi124 wants to merge 2 commits intoAzure:mainfrom
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @rbandi124, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @rbandi124 Release SuggestionsModule: maintenance
Notes
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds new Microsoft.Maintenance ScheduledEvents “list acknowledge” command support and updates scenario tests/metadata to align with the new ScheduledEvents surface.
Changes:
- Introduces
az maintenance scheduledevents list acknowledgeAAZ command implementation. - Renames ScheduledEvent command group/command/parameter to pluralized
scheduledeventsand updates scenario tests accordingly. - Updates test resources/locations and bumps extension minimum CLI core version.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/maintenance/azext_maintenance/tests/latest/test_maintenance_scenario.py | Updates scenario setup (location/SKU/IP) and adds coverage for new scheduledevents list acknowledge. |
| src/maintenance/azext_maintenance/azext_metadata.json | Raises min CLI core version required by the extension. |
| src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevents/list/_acknowledge.py | Adds AAZ command for acknowledging a list of ScheduledEvents IDs. |
| src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevents/list/init.py | Exposes the new scheduledevents list command group and command module. |
| src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevents/list/__cmd_group.py | Registers the maintenance scheduledevents list command group. |
| src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevent/_acknowledge.py | Renames single-event acknowledge command and updates API version/argument name. |
| src/maintenance/azext_maintenance/aaz/latest/maintenance/scheduledevent/__cmd_group.py | Renames the command group from scheduledevent to scheduledevents. |
| az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachinesScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value [] | ||
| az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}" | ||
|
|
||
| :example: Acknowledge list of ScheduledEvents on AvailabilitySets | ||
| az maintenance scheduledvents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets"--resource-name {AvSetname} --value [] |
There was a problem hiding this comment.
The help examples contain command/argument typos that will mislead users: virtualMachinesScaleSets should be virtualMachineScaleSets, and scheduledvents should be scheduledevents (also missing a space before --resource-name in the availability set example). Please correct these example strings.
| az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachinesScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value [] | |
| az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}" | |
| :example: Acknowledge list of ScheduledEvents on AvailabilitySets | |
| az maintenance scheduledvents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets"--resource-name {AvSetname} --value [] | |
| az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachineScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value [] | |
| az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}" | |
| :example: Acknowledge list of ScheduledEvents on AvailabilitySets | |
| az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets" --resource-name {AvSetname} --value [] |
| az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachinesScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value [] | ||
| az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}" | ||
|
|
||
| :example: Acknowledge list of ScheduledEvents on AvailabilitySets | ||
| az maintenance scheduledvents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets"--resource-name {AvSetname} --value [] |
There was a problem hiding this comment.
The help examples contain command/argument typos that will mislead users: virtualMachinesScaleSets should be virtualMachineScaleSets, and scheduledvents should be scheduledevents (also missing a space before --resource-name in the availability set example). Please correct these example strings.
| az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachinesScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value [] | |
| az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}" | |
| :example: Acknowledge list of ScheduledEvents on AvailabilitySets | |
| az maintenance scheduledvents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets"--resource-name {AvSetname} --value [] | |
| az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "virtualMachineScaleSets" --resource-name {VMSSName} --subscription {subscriptionId} --value [] | |
| az maintenance scheduledevents list acknowledge --ids /subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.compute/virtualMachineScaleSets/{VMSSName}/providers/microsoft.maintenance/scheduledevents --body "{value:[]}" | |
| :example: Acknowledge list of ScheduledEvents on AvailabilitySets | |
| az maintenance scheduledevents list acknowledge --resource-group {resourceGroupName} --resource-type "availabilitySets" --resource-name {AvSetname} --value [] |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.