Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @FumingZhang, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Pull request overview
Updates GitHub CODEOWNERS to adjust ownership coverage for the aks-preview extension, intended to route reviews for AKS-related changes to the appropriate maintainers.
Changes:
- Adds
@elvazhu521as a code owner for/src/aks-preview/. - Removes two existing code owners from
/src/aks-preview/ownership.
| /src/interactive/ @jiasli @yanzhudd @ReaNAiveD | ||
|
|
||
| /src/aks-preview/ @andyzhangx @andyliuliming @fumingzhang | ||
| /src/aks-preview/ @fumingzhang @elvazhu521 |
There was a problem hiding this comment.
This change adds @elvazhu521 but also removes @andyzhangx and @andyliuliming as owners for /src/aks-preview/. The PR description only mentions adding Elva; if the removal isn't intentional, please keep the existing owners and append the new one, or update the PR description to reflect the ownership change.
This checklist is used to make sure that common guidelines for a pull request are followed.
Add Elva as code owner of aks command group.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.