[AKS] Allow updating primary agent pool name for load balancer config#9822
[AKS] Allow updating primary agent pool name for load balancer config#9822Liunardy wants to merge 1 commit intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull request overview
Enables az aks loadbalancer update to change the --primary-agent-pool-name for an existing load balancer configuration (previously rejected), and bumps the aks-preview extension version to publish the feature.
Changes:
- Allow
primary_agent_pool_namechanges inaks_loadbalancer_update_internalby treating it as an updatable field (instead of throwingBadRequestError). - Add unit + scenario test coverage validating primary agent pool updates and “no changes requested” behavior.
- Bump extension version to
20.0.0b4and document the change inHISTORY.rst.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/aks-preview/azext_aks_preview/loadbalancerconfiguration.py |
Removes the hard-block on changing primary_agent_pool_name and counts it as a valid update. |
src/aks-preview/azext_aks_preview/tests/latest/test_loadbalancer_configuration.py |
Adds unit tests covering primary agent pool updates + no-op update rejection. |
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py |
Extends the scenario test to validate updating primaryAgentPoolName end-to-end. |
src/aks-preview/setup.py |
Version bump to 20.0.0b4. |
src/aks-preview/HISTORY.rst |
Changelog entry for the new behavior and the release section for 20.0.0b4. |
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
FumingZhang
left a comment
There was a problem hiding this comment.
lgtm
Queued live test to validate the change.
Test failed with error
Please also resolve merge conflict, cc @Liunardy |
d05819a to
bfba063
Compare
Rebased and resolved merge conflict. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Re-queued live test |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks loadbalancer update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.