{appservice-kube} Remove unused compute SDK client factory and completers#9787
{appservice-kube} Remove unused compute SDK client factory and completers#9787william051200 wants to merge 8 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR removes dead compute-related code paths from the appservice-kube extension (compute client factory + VM-size completers), avoiding unnecessary migration work while also bumping the extension patch version.
Changes:
- Remove unused compute client factory (
cf_compute_service) and VM size helper. - Remove unused argument completers for VM size / SKU.
- Bump extension version to
0.1.12and add a corresponding HISTORY entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/appservice-kube/setup.py |
Bumps extension version to 0.1.12. |
src/appservice-kube/azext_appservice_kube/custom.py |
Removes unused get_vm_sizes helper. |
src/appservice-kube/azext_appservice_kube/_completers.py |
Removes unused completer implementations (file now effectively empty). |
src/appservice-kube/azext_appservice_kube/_client_factory.py |
Removes unused compute mgmt client factory. |
src/appservice-kube/HISTORY.rst |
Adds 0.1.12 changelog entry (currently mismatched with the actual PR changes). |
| 0.1.12 | ||
| ++++++ | ||
| * Remove unused completer |
There was a problem hiding this comment.
The 0.1.12 release note says this PR migrates compute operations to AAZ, but the actual change set is removing unused compute client factory/completer code. Please update the HISTORY entry to accurately reflect the user-visible change (e.g., removal of unused compute completers/client factory) to avoid misleading extension consumers.
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
During investigation for migrating compute SDK usage to AAZ-based commands, it was found that the compute client factory and related completer code are not referenced anywhere in the extension. Rather than migrating dead code, this PR removes it entirely
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.