Skip to content

{appservice-kube} Remove unused compute SDK client factory and completers#9787

Open
william051200 wants to merge 8 commits intoAzure:mainfrom
william051200:appservice-kube-migration
Open

{appservice-kube} Remove unused compute SDK client factory and completers#9787
william051200 wants to merge 8 commits intoAzure:mainfrom
william051200:appservice-kube-migration

Conversation

@william051200
Copy link
Copy Markdown
Member

@william051200 william051200 commented Apr 16, 2026

During investigation for migrating compute SDK usage to AAZ-based commands, it was found that the compute client factory and related completer code are not referenced anywhere in the extension. Rather than migrating dead code, this PR removes it entirely


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings April 16, 2026 06:31
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Apr 16, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@william051200 william051200 self-assigned this Apr 16, 2026
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 16, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 2 pipeline(s).

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 2 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes dead compute-related code paths from the appservice-kube extension (compute client factory + VM-size completers), avoiding unnecessary migration work while also bumping the extension patch version.

Changes:

  • Remove unused compute client factory (cf_compute_service) and VM size helper.
  • Remove unused argument completers for VM size / SKU.
  • Bump extension version to 0.1.12 and add a corresponding HISTORY entry.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/appservice-kube/setup.py Bumps extension version to 0.1.12.
src/appservice-kube/azext_appservice_kube/custom.py Removes unused get_vm_sizes helper.
src/appservice-kube/azext_appservice_kube/_completers.py Removes unused completer implementations (file now effectively empty).
src/appservice-kube/azext_appservice_kube/_client_factory.py Removes unused compute mgmt client factory.
src/appservice-kube/HISTORY.rst Adds 0.1.12 changelog entry (currently mismatched with the actual PR changes).

Comment thread src/appservice-kube/HISTORY.rst Outdated
Comment on lines +5 to +7
0.1.12
++++++
* Remove unused completer
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 0.1.12 release note says this PR migrates compute operations to AAZ, but the actual change set is removing unused compute client factory/completer code. Please update the HISTORY entry to accurately reflect the user-visible change (e.g., removal of unused compute completers/client factory) to avoid misleading extension consumers.

Copilot uses AI. Check for mistakes.
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 2 pipeline(s).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

@github-actions github-actions Bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Apr 16, 2026
@yonzhan yonzhan assigned yanzhudd and unassigned zhoxing-ms Apr 16, 2026
@github-actions github-actions Bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants