Skip to content

Added new Parameter "Identities" to configure Multiple MSIs#9782

Open
Balashivaram wants to merge 8 commits intoAzure:mainfrom
Balashivaram:bganesan/eproxy/newidentityparam
Open

Added new Parameter "Identities" to configure Multiple MSIs#9782
Balashivaram wants to merge 8 commits intoAzure:mainfrom
Balashivaram:bganesan/eproxy/newidentityparam

Conversation

@Balashivaram
Copy link
Copy Markdown

@Balashivaram Balashivaram commented Apr 14, 2026


Desrciption:
As part of Explicit Proxy Version V2, we will be supporting both HTTP and HTTPs in single Port configuration and to align with SFI guidelines customer will not be passing PAC File SAS URL instead of that customer will be passing PAC File URL and a UAMI which will have “Storage Blob Data Contributor” and “Storage Blob Data Reader” access to download the file from customer storage, which will be used in data plane to serve Proxy auto configuration

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Azure Firewall Policy Create Command:
az network firewall policy create --name createpremiumfwp1 --resource-group testcli --sku Premium --location centraluseuap --threat-intel-mode Deny --explicit-proxy "{enable-explicit-proxy:true,enable-pac-file:true,http-port:8000,pac-file-port:8001,pac-file:'https://teststgeproxywithrbacfix.blob.core.windows.net/pacfile/proxy.pac'}" --identitities "/subscriptions/e7eb2257-46e4-4826-94df-153853fea38f/resourceGroups/newrgeproxy/providers/Microsoft.ManagedIdentity/userAssignedIdentities/PacFileMSI-testmsirbacfix"
Azure Firewall Policy Update Command:
az network firewall policy update--name updatepremiumfwp--resource-group testcli --sku Premium --location centraluseuap --threat-intel-mode Deny --explicit-proxy "{enable-explicit-proxy:true,enable-pac-file:true,http-port:8000,pac-file-port:8001,pac-file:'https://teststgeproxywithrbacfix.blob.core.windows.net/pacfile/proxy.pac'}" --identitities "/subscriptions/e7eb2257-46e4-4826-94df-153853fea38f/resourceGroups/newrgeproxy/providers/Microsoft.ManagedIdentity/userAssignedIdentities/PacFileMSI-testmsirbacfix"

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Apr 14, 2026

⚠️Azure CLI Extensions Breaking Change Test
⚠️azure-firewall
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network firewall policy create cmd network firewall policy create added parameter identities
⚠️ 1006 - ParaAdd network firewall policy update cmd network firewall policy update added parameter identities

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
2 pipeline(s) require an authorized user to comment /azp run to run.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @Balashivaram,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 14, 2026
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 14, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026

@github-actions
Copy link
Copy Markdown
Contributor

Hi @Balashivaram

Release Suggestions

Module: azure-firewall

  • Please log updates into to src/azure-firewall/HISTORY.rst
  • Update VERSION to 2.2.0 in src/azure-firewall/setup.py

Notes

@necusjz
Copy link
Copy Markdown
Member

necusjz commented Apr 17, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

Comment thread src/azure-firewall/azext_firewall/custom.py
Comment thread src/azure-firewall/azext_firewall/custom.py
Comment thread src/azure-firewall/azext_firewall/custom.py Outdated
@necusjz
Copy link
Copy Markdown
Member

necusjz commented Apr 24, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@cshahra
Copy link
Copy Markdown
Contributor

cshahra commented Apr 27, 2026

Consider adding tests where --identity and --identities are provided together

@cshahra
Copy link
Copy Markdown
Contributor

cshahra commented Apr 27, 2026

LGTM

@bewatersmsft
Copy link
Copy Markdown
Member

Agreed with @cshahra and also LGTM

@necusjz
Copy link
Copy Markdown
Member

necusjz commented Apr 28, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants