refactor(update): replace AxonIQ references with Axoniq#4471
refactor(update): replace AxonIQ references with Axoniq#4471smcvb merged 1 commit intoaxon-5.1.xfrom
AxonIQ references with Axoniq#4471Conversation
MateuszNaKodach
requested review from
hatzlj,
hjohn and
zambrovski
and removed request for
a team
MateuszNaKodach
added
Priority 2: Should
|
|
lgtm |
hatzlj
left a comment
hatzlj
left a comment
There was a problem hiding this comment.
lgtm, would briefly check if the receiving side requires a certain user agent
| String axonBaseVersion = getAxonBaseVersion(); | ||
| return String.format( | ||
| "AxonIQ UpdateChecker/%s (Java %s %s; %s; %s; %s)", | ||
| "Axoniq UpdateChecker/%s (Java %s %s; %s; %s; %s)", |
There was a problem hiding this comment.
is the receiving side expecting AxonIQ as the user-agent?
There was a problem hiding this comment.
@CodeDrivenMitch could you clarify here?
There was a problem hiding this comment.
It's not expecting anything, but values are recorded in SCARF. However, each of these values is also recorded separately.
There was a problem hiding this comment.
It's thus fine to change this, as a new version means a new entry anyway
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
Looks good to me 👍, but let's wait for @CodeDrivenMitch for the open question.
5 participants
No description provided.