[WIP] WIP address feedback on oauth handling for write paths#714
Merged
rickyrombo merged 2 commits intomjp-require-scopefrom Mar 11, 2026
Merged
[WIP] WIP address feedback on oauth handling for write paths#714rickyrombo merged 2 commits intomjp-require-scopefrom
rickyrombo merged 2 commits intomjp-require-scopefrom
Conversation
…ps write endpoints Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
Copilot stopped work on behalf of
rickyrombo due to an error
March 11, 2026 02:34
rickyrombo
added a commit
that referenced
this pull request
Mar 11, 2026
- [x] Identify Developer Apps write endpoints missing `requireAuthMiddleware` + `requireWriteScope` - [x] Add `requireAuthMiddleware` and `requireWriteScope` to all Developer Apps write routes in `api/server.go`: - `POST /developer_apps` and `POST /developer-apps` - `PUT /developer_apps/:address` and `PUT /developer-apps/:address` - `DELETE /developer_apps/:address` and `DELETE /developer-apps/:address` - `POST /developer_apps/:address/access-keys/deactivate` and `POST /developer-apps/:address/access-keys/deactivate` - `POST /developer_apps/:address/access-keys` and `POST /developer-apps/:address/access-keys` - [x] Build verified successfully - [x] Code review passed with no issues <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requireAuthMiddleware+requireWriteScoperequireAuthMiddlewareandrequireWriteScopeto all Developer Apps write routes inapi/server.go:POST /developer_appsandPOST /developer-appsPUT /developer_apps/:addressandPUT /developer-apps/:addressDELETE /developer_apps/:addressandDELETE /developer-apps/:addressPOST /developer_apps/:address/access-keys/deactivateandPOST /developer-apps/:address/access-keys/deactivatePOST /developer_apps/:address/access-keysandPOST /developer-apps/:address/access-keys💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.