Remove swift-snapshot-testing dependency#9
Merged
jcavar merged 2 commits intofeature/licensefrom Dec 10, 2025
Merged
Conversation
jcavar
commented
Nov 28, 2025
| @@ -0,0 +1,8 @@ | |||
| /// Specifies the amplitude scaling method for spectrograms. | |||
Collaborator
Author
There was a problem hiding this comment.
This was existing type, just extracted it to a separate file.
jcavar
commented
Nov 28, 2025
| @@ -0,0 +1,37 @@ | |||
| /// Defines the visualization strategy for audio snapshot failures. | |||
Collaborator
Author
There was a problem hiding this comment.
This matches strategies that we previously had. Just extracted as an enum now as they are not Snapshotting extensions.
jcavar
commented
Nov 28, 2025
| /// - height: The height of the resulting image. | ||
| /// - window: Optional window function for FFT. Uses Hann window if not provided. | ||
| /// - threshold: Minimum amplitude threshold for frequency bins. Defaults to `0.005`. | ||
| /// - Note: Requires iOS 16+ or macOS 13+. |
Collaborator
Author
There was a problem hiding this comment.
This is now a runtime check instead of making all of this iOS 16 dependent. This feels more reasonable.
Contributor
There was a problem hiding this comment.
Does runtime check mean that fatalError if user runs this on lower iOS version?
jcavar
commented
Nov 28, 2025
| @@ -0,0 +1,13 @@ | |||
| import SwiftUI | |||
Collaborator
Author
There was a problem hiding this comment.
Existing typealias-es extracted to a separate file
jcavar
force-pushed
the
feature/no-dependencies
branch
4 times, most recently
from
52ed702 to
e8c6e2f
Compare
jcavar
commented
Nov 29, 2025
| } | ||
|
|
||
| private var xAxisValues: [String] { | ||
| guard !data.isEmpty else { return [] } |
Collaborator
Author
There was a problem hiding this comment.
data[0] was crashing for empty data down below
jcavar
force-pushed
the
feature/no-dependencies
branch
6 times, most recently
from
f06cc62 to
6b68edd
Compare
jcavar
force-pushed
the
feature/no-dependencies
branch
from
6b68edd to
bb7de74
Compare
hhrvoic
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been thinking about this for a while, but I've decided to do it in the end for several reasons: