Build static site from documentation #11
Open
Orhideous wants to merge 5 commits intoAndBondStyle:mainfrom
Open
Build static site from documentation #11Orhideous wants to merge 5 commits intoAndBondStyle:mainfrom
Orhideous wants to merge 5 commits intoAndBondStyle:mainfrom
Conversation
Author
|
Here is a preview: https://orhideous.github.io/niimprint/hardware/ If all goes well, we'll need to replace the repository URL in the |
Author
|
@AndBondStyle Please, take a look :) |
Credits: kjy00302
Owner
|
Taking a look... Well, I see what's cool about a separate site with docs, however with the python library of this size, is it really necessary? I think right now it's more important to just write more docs in plain markdown than migrate them to mkdocs. With that in mind, I still appreciate the work you did. Maybe let's merge it into the "docs" branch, take some time to add more info (info about supported printers, more info about the protocol etc.), and when it'll start to look substantial, we merge it into master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a much more convenient and extensible way to add information about new printers and the various nuances of printing.
This PR replaces #5.