Merged
Conversation
sustripathy
requested review from
alibuild,
jaelpark,
otonvd,
shouqiye and
victor-gonzalez
as code owners
otonvd
approved these changes
Mar 7, 2026
vkucera
reviewed
Mar 8, 2026
Comment on lines
+2687
to
+2696
| const double mass = invariantMass(pr.px, pr.py, pr.pz, MassProton, k.px, k.py, k.pz, MassKaonCharged); | ||
|
|
||
| const float pxTot = pr.px + k.px; | ||
| const float pyTot = pr.py + k.py; | ||
| const float pzTot = pr.pz + k.pz; | ||
| const float ptPair = std::sqrt(pxTot * pxTot + pyTot * pyTot); | ||
| const float phiPair = phiFromPxPy(pxTot, pyTot); | ||
|
|
||
| const double eTot = std::sqrt(mass * mass + static_cast<double>(pxTot) * pxTot + static_cast<double>(pyTot) * pyTot + static_cast<double>(pzTot) * pzTot); | ||
| const float yPair = rapidityFromEPz(eTot, pzTot); |
Collaborator
There was a problem hiding this comment.
Why don't you just use the RecoDecay methods?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit fixes a few minor bugs related to proton candidates.