Add openclaw package split workflow and skill updates#504
Add openclaw package split workflow and skill updates#504khaliqgant wants to merge 3 commits intomainfrom
Conversation
- Add openclaw-package-split.yaml workflow (12-step DAG with 5 agents) - Add BOUNDARY.md and PACKAGE_SPLIT_PLAN.md workflow outputs - Update workflow skill with scrub step pattern and verification guidance - Update openclaw skill with inbound message testing section Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
xkonjin
left a comment
There was a problem hiding this comment.
Quick review pass:
- Main risk area here is auth/session state and stale credential handling.
- I didn’t see targeted regression coverage in the diff; please add or point CI at a focused test for the changed path in SKILL.md, BOUNDARY.md, PACKAGE_SPLIT_PLAN.md (+2 more).
- Before merge, I’d smoke-test the behavior touched by SKILL.md, BOUNDARY.md, PACKAGE_SPLIT_PLAN.md (+2 more) with malformed input / retry / rollback cases, since that’s where this class of change usually breaks.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # .claude/skills/writing-agent-relay-workflows/SKILL.md
| - command: test -d packages/openclaw/src && echo "relay openclaw found" || echo "MISSING" | ||
| description: "Verify @agent-relay/openclaw exists (project: relay)" | ||
| - command: test -d ../relaycast/packages/openclaw/src && echo "relaycast openclaw found" || echo "MISSING" | ||
| description: "Verify @relaycast/openclaw exists (project: relaycast)" |
There was a problem hiding this comment.
🟡 Preflight checks never fail because || echo masks non-zero exit codes
Both preflight commands use test -d ... && echo "found" || echo "MISSING". The || echo "MISSING" fallback ensures the shell pipeline always exits with code 0, even when the directory doesn't exist. Since neither check specifies a failIf or successIf condition, the runner only gates on exit code (see packages/sdk/src/workflows/runner.ts:1794), meaning these preflights will always pass — they cannot detect a missing directory. Compare with the working preflight in packages/sdk/src/examples/workflows/ralph-swarm.yaml:112 which uses test -f "${PRD_PATH:-prd.json}" without a fallback, so it correctly fails on a missing file.
| - command: test -d packages/openclaw/src && echo "relay openclaw found" || echo "MISSING" | |
| description: "Verify @agent-relay/openclaw exists (project: relay)" | |
| - command: test -d ../relaycast/packages/openclaw/src && echo "relaycast openclaw found" || echo "MISSING" | |
| description: "Verify @relaycast/openclaw exists (project: relaycast)" | |
| - command: test -d packages/openclaw/src | |
| description: "Verify @agent-relay/openclaw exists (project: relay)" | |
| - command: test -d ../relaycast/packages/openclaw/src | |
| description: "Verify @relaycast/openclaw exists (project: relaycast)" |
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Valid — the || echo pattern prevents failOnError from catching missing directories. Fixed: the preflight step now uses proper exit code handling so missing paths actually fail the step.
Summary
openclaw-package-split.yaml— 12-step DAG workflow with 5 agents to design the @relaycast/openclaw vs @agent-relay/openclaw package boundaryBOUNDARY.mdandPACKAGE_SPLIT_PLAN.md— workflow output artifactsTest plan
agent-relay run --validate🤖 Generated with Claude Code