Skip to content

Add openclaw package split workflow and skill updates#504

Open
khaliqgant wants to merge 3 commits intomainfrom
workflow-skill-updates
Open

Add openclaw package split workflow and skill updates#504
khaliqgant wants to merge 3 commits intomainfrom
workflow-skill-updates

Conversation

@khaliqgant
Copy link
Member

@khaliqgant khaliqgant commented Mar 6, 2026

Summary

  • Add openclaw-package-split.yaml — 12-step DAG workflow with 5 agents to design the @relaycast/openclaw vs @agent-relay/openclaw package boundary
  • Add BOUNDARY.md and PACKAGE_SPLIT_PLAN.md — workflow output artifacts
  • Update workflow skill with scrub step pattern (prevents PTY output bloat in downstream chaining)
  • Update openclaw skill with inbound message testing section

Test plan

  • Workflow ran end-to-end successfully
  • Both output artifacts generated correctly
  • Validate YAML with agent-relay run --validate

🤖 Generated with Claude Code


Open with Devin

- Add openclaw-package-split.yaml workflow (12-step DAG with 5 agents)
- Add BOUNDARY.md and PACKAGE_SPLIT_PLAN.md workflow outputs
- Update workflow skill with scrub step pattern and verification guidance
- Update openclaw skill with inbound message testing section

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@khaliqgant khaliqgant requested a review from willwashburn as a code owner March 6, 2026 21:49
@khaliqgant khaliqgant mentioned this pull request Mar 6, 2026
2 tasks
devin-ai-integration[bot]

This comment was marked as resolved.

Copy link

@xkonjin xkonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review pass:

  • Main risk area here is auth/session state and stale credential handling.
  • I didn’t see targeted regression coverage in the diff; please add or point CI at a focused test for the changed path in SKILL.md, BOUNDARY.md, PACKAGE_SPLIT_PLAN.md (+2 more).
  • Before merge, I’d smoke-test the behavior touched by SKILL.md, BOUNDARY.md, PACKAGE_SPLIT_PLAN.md (+2 more) with malformed input / retry / rollback cases, since that’s where this class of change usually breaks.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
devin-ai-integration[bot]

This comment was marked as resolved.

# Conflicts:
#	.claude/skills/writing-agent-relay-workflows/SKILL.md
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 8 additional findings in Devin Review.

Open in Devin Review

Comment on lines +48 to +51
- command: test -d packages/openclaw/src && echo "relay openclaw found" || echo "MISSING"
description: "Verify @agent-relay/openclaw exists (project: relay)"
- command: test -d ../relaycast/packages/openclaw/src && echo "relaycast openclaw found" || echo "MISSING"
description: "Verify @relaycast/openclaw exists (project: relaycast)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Preflight checks never fail because || echo masks non-zero exit codes

Both preflight commands use test -d ... && echo "found" || echo "MISSING". The || echo "MISSING" fallback ensures the shell pipeline always exits with code 0, even when the directory doesn't exist. Since neither check specifies a failIf or successIf condition, the runner only gates on exit code (see packages/sdk/src/workflows/runner.ts:1794), meaning these preflights will always pass — they cannot detect a missing directory. Compare with the working preflight in packages/sdk/src/examples/workflows/ralph-swarm.yaml:112 which uses test -f "${PRD_PATH:-prd.json}" without a fallback, so it correctly fails on a missing file.

Suggested change
- command: test -d packages/openclaw/src && echo "relay openclaw found" || echo "MISSING"
description: "Verify @agent-relay/openclaw exists (project: relay)"
- command: test -d ../relaycast/packages/openclaw/src && echo "relaycast openclaw found" || echo "MISSING"
description: "Verify @relaycast/openclaw exists (project: relaycast)"
- command: test -d packages/openclaw/src
description: "Verify @agent-relay/openclaw exists (project: relay)"
- command: test -d ../relaycast/packages/openclaw/src
description: "Verify @relaycast/openclaw exists (project: relaycast)"
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid — the || echo pattern prevents failOnError from catching missing directories. Fixed: the preflight step now uses proper exit code handling so missing paths actually fail the step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants