-
Notifications
You must be signed in to change notification settings - Fork 151
[management] Code generation: update services and models #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "service": "management", | ||
| "project": "java", | ||
| "generatedAt": "2026-04-15T07:56:34Z", | ||
| "openapiCommitSha": "3550ecd3f320efaad6bee55ffed5122cb9ba09d5", | ||
| "automationCommitSha": "1ceda93a33430aa189b6141d5f6ea2e61051c7fd", | ||
| "libraryCommitSha": "006de89d9ba7bca5c80eca48bcb5ee5829e763cb" | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -45,8 +45,8 @@ public class AndroidApp { | |||||
| private boolean isSetDescription = false; | ||||||
|
|
||||||
| public static final String JSON_PROPERTY_ERROR_CODE = "errorCode"; | ||||||
| @Deprecated // deprecated since Management API v3: Use `errors` instead. | ||||||
| private String errorCode; | ||||||
| /* deprecated since Management API v3: Use `errors` instead. */ | ||||||
| @Deprecated private String errorCode; | ||||||
|
|
||||||
| /** Mark when the attribute has been explicitly set. */ | ||||||
| private boolean isSetErrorCode = false; | ||||||
|
|
@@ -204,9 +204,9 @@ public void setDescription(String description) { | |||||
| * @param errorCode The error code of the Android app with the `status` of either | ||||||
| * **error** or **invalid**. | ||||||
| * @return the current {@code AndroidApp} instance, allowing for method chaining | ||||||
| * @deprecated since Management API v3 Use `errors` instead. | ||||||
| * @deprecated since Management API v3 Use `errors` instead. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Javadoc uses backticks (
Suggested change
|
||||||
| */ | ||||||
| @Deprecated // deprecated since Management API v3: Use `errors` instead. | ||||||
| @Deprecated | ||||||
| public AndroidApp errorCode(String errorCode) { | ||||||
| this.errorCode = errorCode; | ||||||
| isSetErrorCode = true; // mark as set | ||||||
|
|
@@ -219,9 +219,9 @@ public AndroidApp errorCode(String errorCode) { | |||||
| * | ||||||
| * @return errorCode The error code of the Android app with the `status` of either | ||||||
| * **error** or **invalid**. | ||||||
| * @deprecated // deprecated since Management API v3: Use `errors` instead. | ||||||
| * @deprecated since Management API v3 Use `errors` instead. | ||||||
| */ | ||||||
| @Deprecated // deprecated since Management API v3: Use `errors` instead. | ||||||
| @Deprecated | ||||||
| @JsonProperty(JSON_PROPERTY_ERROR_CODE) | ||||||
| @JsonInclude(value = JsonInclude.Include.USE_DEFAULTS) | ||||||
| public String getErrorCode() { | ||||||
|
|
@@ -234,9 +234,9 @@ public String getErrorCode() { | |||||
| * | ||||||
| * @param errorCode The error code of the Android app with the `status` of either | ||||||
| * **error** or **invalid**. | ||||||
| * @deprecated since Management API v3 Use `errors` instead. | ||||||
| * @deprecated since Management API v3 Use `errors` instead. | ||||||
| */ | ||||||
| @Deprecated // deprecated since Management API v3: Use `errors` instead. | ||||||
| @Deprecated | ||||||
| @JsonProperty(JSON_PROPERTY_ERROR_CODE) | ||||||
| @JsonInclude(value = JsonInclude.Include.USE_DEFAULTS) | ||||||
| public void setErrorCode(String errorCode) { | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -203,9 +203,8 @@ public class UpdatePaymentMethodInfo { | |||||||||||||||||
| private boolean isSetStoreId = false; | ||||||||||||||||||
|
|
||||||||||||||||||
| public static final String JSON_PROPERTY_STORE_IDS = "storeIds"; | ||||||||||||||||||
| @Deprecated // deprecated since Management API v3: Use `storeId` instead. Only one store per | ||||||||||||||||||
| // payment method is allowed. | ||||||||||||||||||
| private List<String> storeIds; | ||||||||||||||||||
| /* deprecated since Management API v3: Use `storeId` instead. Only one store per payment method is allowed. */ | ||||||||||||||||||
| @Deprecated private List<String> storeIds; | ||||||||||||||||||
|
Comment on lines
+206
to
+207
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line is excessively long (114 characters), exceeding common line length limits such as the 100-character limit in Google Java Style. Furthermore, using a regular block comment for deprecation is less effective than Javadoc (
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| /** Mark when the attribute has been explicitly set. */ | ||||||||||||||||||
| private boolean isSetStoreIds = false; | ||||||||||||||||||
|
|
@@ -1143,11 +1142,10 @@ public void setStoreId(String storeId) { | |||||||||||||||||
| * | ||||||||||||||||||
| * @param storeIds The list of stores for this payment method | ||||||||||||||||||
| * @return the current {@code UpdatePaymentMethodInfo} instance, allowing for method chaining | ||||||||||||||||||
| * @deprecated since Management API v3 Use `storeId` instead. Only one store per payment | ||||||||||||||||||
| * method is allowed. | ||||||||||||||||||
| * @deprecated since Management API v3 Use `storeId` instead. Only one store per payment method is | ||||||||||||||||||
| * allowed. | ||||||||||||||||||
|
Comment on lines
+1145
to
+1146
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Javadoc uses backticks (
Suggested change
|
||||||||||||||||||
| */ | ||||||||||||||||||
| @Deprecated // deprecated since Management API v3: Use `storeId` instead. Only one store per | ||||||||||||||||||
| // payment method is allowed. | ||||||||||||||||||
| @Deprecated | ||||||||||||||||||
| public UpdatePaymentMethodInfo storeIds(List<String> storeIds) { | ||||||||||||||||||
| this.storeIds = storeIds; | ||||||||||||||||||
| isSetStoreIds = true; // mark as set | ||||||||||||||||||
|
|
@@ -1166,11 +1164,10 @@ public UpdatePaymentMethodInfo addStoreIdsItem(String storeIdsItem) { | |||||||||||||||||
| * The list of stores for this payment method | ||||||||||||||||||
| * | ||||||||||||||||||
| * @return storeIds The list of stores for this payment method | ||||||||||||||||||
| * @deprecated // deprecated since Management API v3: Use `storeId` instead. Only one store per | ||||||||||||||||||
| * payment method is allowed. | ||||||||||||||||||
| * @deprecated since Management API v3 Use `storeId` instead. Only one store per payment method is | ||||||||||||||||||
| * allowed. | ||||||||||||||||||
| */ | ||||||||||||||||||
| @Deprecated // deprecated since Management API v3: Use `storeId` instead. Only one store per | ||||||||||||||||||
| // payment method is allowed. | ||||||||||||||||||
| @Deprecated | ||||||||||||||||||
| @JsonProperty(JSON_PROPERTY_STORE_IDS) | ||||||||||||||||||
| @JsonInclude(value = JsonInclude.Include.USE_DEFAULTS) | ||||||||||||||||||
| public List<String> getStoreIds() { | ||||||||||||||||||
|
|
@@ -1181,11 +1178,10 @@ public List<String> getStoreIds() { | |||||||||||||||||
| * The list of stores for this payment method | ||||||||||||||||||
| * | ||||||||||||||||||
| * @param storeIds The list of stores for this payment method | ||||||||||||||||||
| * @deprecated since Management API v3 Use `storeId` instead. Only one store per payment | ||||||||||||||||||
| * method is allowed. | ||||||||||||||||||
| * @deprecated since Management API v3 Use `storeId` instead. Only one store per payment method is | ||||||||||||||||||
| * allowed. | ||||||||||||||||||
| */ | ||||||||||||||||||
| @Deprecated // deprecated since Management API v3: Use `storeId` instead. Only one store per | ||||||||||||||||||
| // payment method is allowed. | ||||||||||||||||||
| @Deprecated | ||||||||||||||||||
| @JsonProperty(JSON_PROPERTY_STORE_IDS) | ||||||||||||||||||
| @JsonInclude(value = JsonInclude.Include.USE_DEFAULTS) | ||||||||||||||||||
| public void setStoreIds(List<String> storeIds) { | ||||||||||||||||||
|
|
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a regular block comment (
/* ... */) for deprecation is less effective than Javadoc (/** ... */), which is recognized by IDEs and documentation tools. Additionally, placing the annotation on the same line as the field can reduce visibility. It is recommended to use a multi-line Javadoc format and place the annotation on its own line.