Skip to content

Consolidate Redis and Valkey Best Practices Recommendations and updating the configurations#172

Closed
rimomcosta wants to merge 6 commits intoAdobeDocs:mainfrom
rimomcosta:redis-valkey-consolidation
Closed

Consolidate Redis and Valkey Best Practices Recommendations and updating the configurations#172
rimomcosta wants to merge 6 commits intoAdobeDocs:mainfrom
rimomcosta:redis-valkey-consolidation

Conversation

@rimomcosta
Copy link
Copy Markdown

@rimomcosta rimomcosta commented Mar 10, 2026

Purpose of this pull request

This pull request consolidates the Redis and Valkey best practices recommendations into a single implementation playbook topic and updates the related configuration guidance.

It also removes the redundant standalone Redis and Valkey planning articles and updates the TOC, planning overview, redirects, and What's New references so navigation and existing links resolve to the consolidated topic.

Affected pages

Additional information

Related PR against Commerce on Cloud Guide: Remove outdated warning on REDIS and VALKEY cache configuration options

What's New highlights

whatsnew
Updated the best practices for Redis and Valkey configuration and provides related configuration guidance.

Add a unified Redis/Valkey service configuration topic to the implementation playbook and remove the now-redundant standalone Redis and Valkey planning articles.

Update the planning TOC, overview entry, redirects, and What's New references so navigation and historical links now resolve to the consolidated topic.
@rimomcosta rimomcosta requested a review from dshevtsov as a code owner March 10, 2026 16:28
@github-project-automation github-project-automation Bot moved this to 📋 Needs Review in Commerce - Pull Requests Mar 10, 2026
@rimomcosta rimomcosta changed the title Consolidate Redis and Valkey planning guidance Consolidate Redis and Valkey Best Practices Recommendations and updating the configurations Mar 10, 2026
@meker12 meker12 self-assigned this Mar 10, 2026
@meker12 meker12 added the major-update Significant original updates to existing content label Mar 10, 2026
@meker12 meker12 requested review from meker12 and removed request for dshevtsov and meker12 March 10, 2026 23:05
@dshevtsov dshevtsov moved this from 📋 Needs Review to 🧑‍💻 In Progress in Commerce - Pull Requests Mar 11, 2026
@rimomcosta rimomcosta force-pushed the redis-valkey-consolidation branch from d957372 to 8ee1b34 Compare March 11, 2026 11:15
Copy link
Copy Markdown

@prateek-karanpuria-adobe prateek-karanpuria-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While re-reviewing the merged document, I noticed that some Valkey-specific references from the original Valkey document were not included in the consolidated version. To fully preserve content from both Redis and Valkey documents, a few updates are needed in the following sections:

  1. Configure Redis L2 cache section

    • Currently references REDIS_BACKEND.
    • The Valkey equivalent VALKEY_BACKEND should also be mentioned for Valkey deployments.
  2. Enable Redis slave connection section

    • Currently documents REDIS_USE_SLAVE_CONNECTION.
    • The Valkey equivalent VALKEY_USE_SLAVE_CONNECTION should also be included.
  3. Additional information section

    • Only Redis documentation links are referenced.
    • Valkey documentation links (valkey-pg-cache, valkey-session) should also be added.
  4. Deployment log example in the Redis session separation section

    • The example currently references:
      • service 'redis'
      • service 'redis-session'
    • A corresponding Valkey example (valkey, valkey-session) should also be included.

Because of these omissions, the combine document does not yet fully preserve all information from both the Redis and Valkey original files.

@github-project-automation github-project-automation Bot moved this from 🧑‍💻 In Progress to 🛠 Changes Requested in Commerce - Pull Requests Mar 11, 2026
@rimomcosta
Copy link
Copy Markdown
Author

While re-reviewing the merged document, I noticed that some Valkey-specific references from the original Valkey document were not included in the consolidated version. To fully preserve content from both Redis and Valkey documents, a few updates are needed in the following sections:

  1. Configure Redis L2 cache section

    • Currently references REDIS_BACKEND.
    • The Valkey equivalent VALKEY_BACKEND should also be mentioned for Valkey deployments.
  2. Enable Redis slave connection section

    • Currently documents REDIS_USE_SLAVE_CONNECTION.
    • The Valkey equivalent VALKEY_USE_SLAVE_CONNECTION should also be included.
  3. Additional information section

    • Only Redis documentation links are referenced.
    • Valkey documentation links (valkey-pg-cache, valkey-session) should also be added.
  4. Deployment log example in the Redis session separation section

    • The example currently references:

      • service 'redis'
      • service 'redis-session'
    • A corresponding Valkey example (valkey, valkey-session) should also be included.

Because of these omissions, the combine document does not yet fully preserve all information from both the Redis and Valkey original files.

All those points are referenced:
1:
image

2:
image

3:
"Only Redis documentation links are referenced" - The original document also misses this, so this is out of scope of this merge.
"Valkey documentation links (valkey-pg-cache) should also be added." - Again, out of scope, it also is missing in the original document.
"valkey-session" - This is also well documented here:
image

4:
valkey is fully covered in the examples as well:
image

The current documentation is not just a combination, it fixes several errors from the original documentation and goes even beyond.

Please check again.

Regards

@rimomcosta
Copy link
Copy Markdown
Author

rimomcosta commented Mar 12, 2026

Hi Reviewers,

Please refrain from using AI for this review. Those configurations are way too specific and one of the most sensitive for the merchant's environment.

Also, please add the comments in line, example:
image

Thank you a lot,
Regards,

Copy link
Copy Markdown

@prateek-karanpuria-adobe prateek-karanpuria-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rimomcosta - Thanks for the detailed look at the PR comment. However, I do see some important links about valkey-pg-cache already present in the original document as well. Could you please have a look and do the needful? Thanks.

Image Image Image

@meker12
Copy link
Copy Markdown
Contributor

meker12 commented Mar 12, 2026

This PR has been imported to the enterprise repo. Any further updates need to be made in the imported PR.

@AdobeDocs AdobeDocs deleted a comment from andriyShevtsov Apr 3, 2026
@dshevtsov
Copy link
Copy Markdown
Contributor

Addressed in c96e5b3.

@dshevtsov dshevtsov closed this Apr 3, 2026
@github-project-automation github-project-automation Bot moved this from 🛠 Changes Requested to 🏁 Done in Commerce - Pull Requests Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major-update Significant original updates to existing content

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants