AArch64 asm clobbers: recognize more register names#576
Open
xavierleroy wants to merge 1 commit intomasterfrom
Open
AArch64 asm clobbers: recognize more register names#576xavierleroy wants to merge 1 commit intomasterfrom
xavierleroy wants to merge 1 commit intomasterfrom
Conversation
Wn as alias for Xn (integer register) Vn Qn Sn Hn Bn as aliases for Dn (floating-point/vector register) Fixes: #569
xavierleroy
force-pushed
the
aarch64-register-aliases
branch
from
4ec1df3 to
7d9e5f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #569, in the "clobbers" clause of
asmstatements, CompCert recognizes fewer AArch64 register names than GCC or Clang. The suggestion was to acceptThis PR implements this suggestion in the most stupid possible way, with an extra table of aliases. #569 suggested a more concise approach, but it extracts to awful OCaml code, impossible to review manually.
Fixes: #569