Fix erroneous read of extra word in swd_read_block()#194
Merged
c1728p9 merged 1 commit intoARMmbed:masterfrom Nov 30, 2016
Merged
Fix erroneous read of extra word in swd_read_block()#194c1728p9 merged 1 commit intoARMmbed:masterfrom
c1728p9 merged 1 commit intoARMmbed:masterfrom
Conversation
- Also replaced some literal constants with macros to improve readability.
Contributor
|
Thanks for the detailed investigation of this @flit. |
Contributor
|
@mbed-bot: TEST |
c1728p9
reviewed
Nov 29, 2016
Contributor
c1728p9
left a comment
c1728p9
left a comment
There was a problem hiding this comment.
Is this same change also relevant to cortex-A?
Collaborator
Author
|
@c1728p9 Good question about Cortex-A, I'll check. |
Collaborator
Author
|
@c1728p9 |
Contributor
|
Ah, didn't realize that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swd_read_block()was always causing the AP to issue a read of an extra word.This is the root cause of the problem that was also addressed by #189. On Kinetis devices where the UID is read, the bug causes the word after the last UID register, an invalid register on most devices, to also be read. (#189 is still useful on its own, will continue to work on it.)
Verified that the UID is still successfully read as the same value before and after the patch.
Also replaced some literal constants in
swd_read_block()with macros to improve readability.