ADD: Integration tests for radar preprocessing with baseline image comparison#20
Merged
rcjackson merged 1 commit intoARM-Development:mainfrom Apr 23, 2026
Merged
Conversation
Collaborator
rcjackson
commented
Apr 23, 2026
rcjackson
commented
- Fix issue with plot markers being in radar image
- Fix sweep_mode parsing to handle CF/Radial 'azimuth_surveillance' mode (null-byte-delimited string) alongside 'ppi' and 'sector'
- Fix ref_min/ref_max computation to use np.nanmin/nanmax and a local variable instead of reassigning the min_ref parameter (which caused NaN)
- Add numpy import to radar_preprocessing.py
- Add open-radar-data to dev dependencies
- Add tests/integration/ with conftest that removes unit-test mocks so real xradar/cmweather are used
- Add baseline PNGs in tests/data/baseline/preprocessing/ for the three GUC XPRECIP CMAC PPI files from open-radar-data
…mparison - Fix sweep_mode parsing to handle CF/Radial 'azimuth_surveillance' mode (null-byte-delimited string) alongside 'ppi' and 'sector' - Fix ref_min/ref_max computation to use np.nanmin/nanmax and a local variable instead of reassigning the min_ref parameter (which caused NaN) - Add numpy import to radar_preprocessing.py - Add open-radar-data to dev dependencies - Add tests/integration/ with conftest that removes unit-test mocks so real xradar/cmweather are used - Add baseline PNGs in tests/data/baseline/preprocessing/ for the three GUC XPRECIP CMAC PPI files from open-radar-data Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.