Refactor chart preview flow to reuse a single chart ID#479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
chart_idis used end-to-end for chart preview generation, URL construction, and serving so preview lookup is deterministic and cannot fail due to mismatched IDs.Description
chart_idonce in the preview handler and pass it intoBrollService.generate_chart_preview(...)so the service writes the file with the same ID. (backend/api/podcast/handlers/broll.py).get_chart_preview_filename()andget_chart_preview_path()toBrollService, and makegenerate_chart_preview(...)accept an optionalchart_idto allow controlled filenames. (backend/services/podcast/broll_service.py).chart_id, and validate the incoming filename inserve_chart_preview()by comparing it toget_chart_preview_filename(chart_id)before serving. (backend/api/podcast/handlers/broll.py).Testing
python -m py_compile backend/api/podcast/handlers/broll.py backend/services/podcast/broll_service.pywhich completed successfully.Codex Task