libafl_qemu: Returning errors in snapshots on saving and loading #3764
Open
Tanmay140906 wants to merge 2 commits intoAFLplusplus:mainfrom
Open
libafl_qemu: Returning errors in snapshots on saving and loading #3764Tanmay140906 wants to merge 2 commits intoAFLplusplus:mainfrom
Tanmay140906 wants to merge 2 commits intoAFLplusplus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR propagates snapshot errors from QEMU to Rust by:
libafl_save_qemu_snapshotandlibafl_load_qemu_snapshotto returnint-1on failure and0on successResult<(), QemuSnapshotError>Async snapshot mode failure reports need to be handled yet.
Fixes #1512
Since the qemu_snapshot file and it's functions are generated during build time, these are the recommended changes to make so that this causes no code to break and works fine:
Changes
1.
libafl/qemu_snapshot.cChecklist
./scripts/precommit.shand addressed all comments