Open
Conversation
nathan-muir
force-pushed
the
credstash
branch
from
0ea15e9 to
03b0dd3
Compare
nathan-muir
force-pushed
the
master
branch
2 times, most recently
from
78ba2ca to
ca49f10
Compare
Consolidate api/cli into a single core module. It's now much easier to load & call credsmash via python. Core - Perform version/compare before sealing new secret. DynamoDB - Create separate `get_one` and `get_latest`. This also removes the `name` & `version` from the ciphertext output, as it is an implementation detail of how DynamoDB stores data.
Crypto - Support additional authenticated data on key service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to create a CLI that is 100% compatible with
credstash, using the API's ofcredsmashBased on the work thus far, the following breaking changes must be resolved:
P1 Removed these options:
--region,--profileor--arnas they can be configured viaboto3See History.md.region,profileandarntocredsmash.boto3.get_session, use@lru_cache.P2 Removed
--versiononcredstash getallversionoption toCredsmash.get_allandCredsmash.find_manyP3 Removed
--digestoncredstash put, & uses incompatible algoalgorithm/algorithm_optionsto be configured withCredsmash.get_sessionor instantiateCredsmashmanually in the credstash cli.P4 Missing cosmetic features added to CLI since
credstash==1.12.0credstash>1.12.0