Fix daemon thread, is_same_loop detection, and run_threadsafe timeout…#4
Open
nerod10 wants to merge 1 commit into3mora2:mainfrom
Open
Fix daemon thread, is_same_loop detection, and run_threadsafe timeout…#4nerod10 wants to merge 1 commit into3mora2:mainfrom
nerod10 wants to merge 1 commit into3mora2:mainfrom
Conversation
… handling - Set browser thread as daemon=True so it doesn't block process exit - Replace get_event_loop() with get_running_loop() for correct same-loop detection - Always signal completion event in finally block to prevent deadlock on task failure - Raise TimeoutError and cancel task when run_threadsafe exceeds timeout Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… handling