feat(PT9-383): use server-resolved source from quote response for order building#173
Open
feat(PT9-383): use server-resolved source from quote response for order building#173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What does this PR change?
sourcefield from the/receiveAPI responsesourceif the API response doesn't include one (backward compat with older API versions)Changes
types.tssourcetoQuoterResponsequote/quote.tsresponse.source, usethis.source || this.params.sourceincreateFusionOrderquoter.api.spec.tsBackward compatibility
sourceis optional in the response typesource→ SDK falls back tothis.params.source(existing behavior)Related Issue/Ticket:
https://1inch.atlassian.net/browse/PT9-383
Testing & Verification
How was this tested?
Risk Assessment
Risk Level:
Risks & Impact