Skip to content

Migrate to the client v0.14#37

Open
greenhat wants to merge 16 commits intomainfrom
migrate-clien-v014
Open

Migrate to the client v0.14#37
greenhat wants to merge 16 commits intomainfrom
migrate-clien-v014

Conversation

@greenhat
Copy link
Copy Markdown
Contributor

@greenhat greenhat commented Mar 30, 2026

TODO:

  • switch to the released cargo-miden and move git tag;
  • migrate agent skills;
  • switch to the published miden-client v0.14;
  • move the v0.10 git tag;

Keinberger

This comment was marked as resolved.

@greenhat
Copy link
Copy Markdown
Contributor Author

Thank you! Fixed.

@greenhat greenhat requested a review from Keinberger April 14, 2026 08:31
@greenhat greenhat force-pushed the migrate-clien-v014 branch from c3a8256 to 290fbed Compare April 15, 2026 11:01
@greenhat
Copy link
Copy Markdown
Contributor Author

@Keinberger Could you please do another round? I've removed some helpers and used the new mockchain API.

Keinberger

This comment was marked as resolved.

Copy link
Copy Markdown
Collaborator

@Keinberger Keinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @greenhat, looking good, but there are two SKILL issue swe should get rid of before merging.

Left inline comments below with specifics.

Nothing else blocking from my side. Minor nits while we're at it:

  • Typo "Crate" -> "Create" on counter_test.rs:23
  • Commented-out debug block at increment_count.rs:92-95

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was rewritten to use MockChain::builder() + AccountComponent::from_package + add_account_from_builder + NoteBuilder, but this skill file still references APIs that no longer exist in this PR: create_testing_account_from_package, create_testing_note_from_package, NoteCreationConfig, StorageSlot::with_map / StorageSlot::with_value, StorageSlotName, AccountCreationConfig, and apply_delta().

The stale API references appear on multiple lines between 51 and 162 (and the validation checklist mentions apply_delta() which the new test doesn't use). The counter_test.rs line number references throughout the file are also off since the test was rewritten.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have duplicate pitfall numbers from the PR #36 merge. P8 appears twice:

  • Line 138: P8: Recipient::compute Was Removed
  • Line 183: P8: NoteType Variants Unavailable in Compiler SDK

Same with P9:

  • Line 155: P9: P2ID Note Root Hardcoding
  • Line 197: P9: Note Scripts Cannot Call Native Account Functions

Also the (see P8) cross-reference in the original P9 body is now ambiguous. I think renumbering the PR #36 pitfalls to P10/P11/P12 (since there's already a P10 at line 205, it'd need to be P11/P12/P13) fixes both in one pass.

Refresh the testing guidance to match `InitStorageData`, `AccountComponent::from_package`, `NoteBuilder`, and `RawOutputNote` flows. Also fix the duplicated pitfall numbering and clean up the review nits in the integration example and test.
@greenhat
Copy link
Copy Markdown
Contributor Author

Thank you! Fixed. Please do another round.

@greenhat greenhat requested a review from Keinberger April 17, 2026 09:46
Copy link
Copy Markdown
Collaborator

@Keinberger Keinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @greenhat, one small thing in .claude/skills/rust-sdk-source-guide/SKILL.md: the clone instruction points to keinberger/miden-bank, but the in-skill links elsewhere all reference 0xMiden/tutorials/blob/main/examples/miden-bank/. We should point the clone to 0xMiden/tutorials as well for consistency. The old repo under my personal github name is outdated.

Otherwise the PR looks good to me, approving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants