chore: simplify network monitor counter script#1957
chore: simplify network monitor counter script#1957SantiagoPittella wants to merge 1 commit intomainfrom
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-simplify-monitor-library
branch
from
218982c to
a86848d
Compare
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
LGTM! Quick question, should we change the criteria for marking the card as unhealthy? The numbers are signaling that something is off:
| let script_builder = CodeBuilder::new() | ||
| .with_dynamically_linked_library(&library) |
There was a problem hiding this comment.
To give some more context (correct me if I'm wrong @SantiagoPittella), this was failing due to 0xMiden/miden-vm#2986, as this CodeBuilder was not sharing the same source manager as the library. On Linux for some reason this is not failing (which is why the monitor did not show errors AFAIK) but when testing this locally on MacOS it would panic cc @bitwalker
There was a problem hiding this comment.
Yes, this is correct.
There was a problem hiding this comment.
(and regarding the review comment above this, I will add it to the existing issue of improvements)
2 participants
Due to upstream changes, and considering that we are about to do a new release, this PR adds a simplification to the counter creation and fixes the source manager handling following the changes from 0xMiden/miden-client#2006