Skip to content

fix: chain tip race condition#1953

Open
SantiagoPittella wants to merge 4 commits intomainfrom
santiagopittella-fix-chain-tip-race-condition
Open

fix: chain tip race condition#1953
SantiagoPittella wants to merge 4 commits intomainfrom
santiagopittella-fix-chain-tip-race-condition

Conversation

@SantiagoPittella
Copy link
Copy Markdown
Collaborator

closes #1951

If the event is for a block we already received from the store, we skip it. If it's genuinely new, we proceed as we used to.

Copy link
Copy Markdown
Collaborator

@sergerad sergerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I encountered this in #1901

Copy link
Copy Markdown
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's much cleaner than my suggestions, thank you!

@SantiagoPittella
Copy link
Copy Markdown
Collaborator Author

@Mirko-von-Leipzig before merging this, should I mark the changelog section of 0.14.8 with today's date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants