Open
Conversation
Collaborator
Author
|
Goes on top of #812. |
Collaborator
Author
djolertrk
force-pushed
the
feature/debug-variable-locations-clean
branch
3 times, most recently
from
69877ae to
a4ccd95
Compare
Collaborator
Author
|
It depends on the types and debug decorator defined in 0xMiden/miden-vm#2471. |
Collaborator
|
I've done an initial review of the |
djolertrk
force-pushed
the
feature/debug-variable-locations-clean
branch
from
a4ccd95 to
885283c
Compare
This was referenced Jan 19, 2026
djolertrk
force-pushed
the
feature/debug-variable-locations-clean
branch
from
5397179 to
a3fc070
Compare
Collaborator
Author
|
Now rebased on top of #995. |
Collaborator
Author
|
Status on this: VM changes merged |
Contributor
djolertrk
force-pushed
the
feature/debug-variable-locations-clean
branch
from
a3fc070 to
a20d993
Compare
Collaborator
Author
|
rebased on top of #995 |
djolertrk
force-pushed
the
feature/debug-variable-locations-clean
branch
2 times, most recently
from
7647605 to
92b8973
Compare
Collaborator
Author
|
note that it still depends on the local |
This commit adds debug information support for tracking variable locations through the compilation pipeline: - Add debug info representation on HIR level (builtin.dbg_value ops, DIExpression, DILocalVariable attributes) - Handle DebugVars during lowering from HIR to MASM - Add DebugInfoBuilder for constructing debug metadata - Add RemoveDeadDebugOps pass to clean up debug ops with dead operands - Add miden-debugdump tool for inspecting .debug_info sections in MASP packages (similar to llvm-dwarfdump) - Add documentation for the debug info format (docs/DebugInfoFormat.md, docs/DebugInfoMetadata.md) - Add lit tests for debug functionality Run tests: $ litcheck lit run --verbose tests/lit/debugdump $ litcheck lit run --path bin ./tests/lit/debug/
- Check if WasmLocal value is on Miden operand stack before assuming it's in local memory (emit Stack(pos) if on stack) - Add post-processing in MasmFunctionBuilder::build() to patch Local(idx) with correct FMP offset - Compute num_wasm_locals = params_in_felts + hir_locals for correct offset calculation (DWARF WasmLocal uses WASM indexing where params come first) - Add patch_debug_var_locals_in_block() to recursively patch all DebugVar decorators in the MASM body
Confirm that cfg --> scf preserves debug info
Debug info operations (debuginfo.value, debuginfo.kill, debuginfo.declare) are purely observational and were causing panics and assembler validation errors when they survived through optimization passes into codegen. - Skip operand scheduling for DebugValue (observational, not consuming) - Gracefully skip debuginfo ops with no HirLowering in the emitter - Make SinkOperandDefs and ControlFlowSink debug-info-aware so debug uses don't block sinking or prevent dead code elimination - Strip DebugVar-only procedure bodies that would be rejected by the Miden assembler (decorators without instructions have no MAST effect)
Add end-to-end debug variable location tracking through the compiler pipeline, and patch miden-vm to fix a crash when basic blocks are deduplicated during assembly.
Fix data_offset_align and raw_entity_metadata_layout_for_value_layout to correctly handle types with alignment > 8
- add FrameBase lowering - DWARF parsing (parse variable/params names) - and fix duplicate DebugVar emissions
djolertrk
force-pushed
the
feature/debug-variable-locations-clean
branch
from
0987c07 to
468609e
Compare
Collaborator
Author
|
NOTE: It uses https://github.com/walnuthq/miden-vm/tree/fix/debug-var-dedup-crash -- but 0xMiden/miden-vm#2955 should be merged soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track variable locations at HIR and MASM levels.
Add DebugVar decorator and new debug_info section in the final .masp.
Also, add
miden-debugdumptool to dump .debug_info section, so we can explore the custom section from the package.vm part: 0xMiden/miden-vm#2471