Enforce errors for missing items in Import::Partial#473
Open
GarmashAlex wants to merge 1 commit into0xMiden:nextfrom
Open
Enforce errors for missing items in Import::Partial#473GarmashAlex wants to merge 1 commit into0xMiden:nextfrom
GarmashAlex wants to merge 1 commit into0xMiden:nextfrom
Conversation
GarmashAlex
commented
Sep 26, 2025
- Switched partial import resolution to iterate requested items and resolve each via Module::get(&Identifier).
- If an item is not exported by the source module, return ImportUndefined(from) instead of silently ignoring it.
- This prevents no-op imports, aligns behavior with the ImportUndefined error semantics and user expectations for explicit imports, and improves diagnostics by surfacing incorrect use statements early.
Collaborator
|
Hey! Do you mind adding a test case, or at least sharing a set of air-script files where the issue is present, so we can compare this implementation and the existing one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.