Integrate into tlaplus/tlaplus repo?

[lemmy]

What are your thoughts on donating and integrating your formatter into the tlaplus/tlaplus GitHub repository? Are there any blockers (missing features, required refactoring, or external dependencies) that would make this too early or infeasible right now? Integrating it upstream would make the formatter immediately available to all users and would also ensure that updates automatically flow into the TLA+ VSCode extension.

[FedericoPonzi]

I'm happy to see the formatter moved upstream. I haven't looked into what it would take to integrate it to the tlaplus/tlaplus project yet. If you wanna take a stab at it feel free to give it a shot.

I don't think there are big refactorings needed. Feature-wise, the big one would be coming up with a config file, but it is not something I wanna do until I get some feedback (e.g. two users coming with opposing requests). I think it's the easiest way to go about it. But in any case, this can be worked on the main repo as well.

[lemmy]

From an IP and contribution standpoint, it would be good if the PR were yours.

[FedericoPonzi]

As an alternative, we can also consider to just move the repo under tlaplus org. The vscode extension has already the necessary wirings to pull the latest formatter version on build: https://github.com/tlaplus/vscode-tlaplus/blob/0c78f9fc4bcadb167b105993c4b92598edfc3a78/.github/workflows/release.yml#L40
I can release a new formatter version, and then we just need to run a new build for the extension. Updating the formatter's release process to trigger vscode builds like tlaplus repo is doing, would complete the automatic flow.

[FedericoPonzi]

From an IP and contribution standpoint, it would be good if the PR were yours.

It makes sense, in that case I'll need some time to see how to integrate the formatter into tlatools. I'll try to create a draft pr by the end of this week.

[lemmy]

Just tell me if and how you want to move forward. :-)

[FedericoPonzi]

I'm happy to donate the code and I don't have a strong opinion on where it should reside. If you think it's more convenient to keep it within the tlatools then it's fine by me. IMO having the versioning system it makes it easier to evolve. I know tlatools uses the rolling release model, but I find it hard at times as you can never deprecate anything. That's just my point of view though. I'll share an update by the end of this week, let me see what would it take to include it in tlatools.

[lemmy]

Move it over as a first step?

[FedericoPonzi]

You don’t have the permission to create public repositories on tlaplus

I've sent the transfer request to your account